Date: Sat, 22 Aug 2015 13:23:10 +0530
From: Afzal Mohammed <afzal.mohd.ma@gmail.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: yalin wang <yalin.wang2010@gmail.com>, adaplas@gmail.com,
        plagnioj@jcrosoft.com, linux-fbdev@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] fbdev/riva:change to use generice function to implement
 reverse_order()
Message-ID: <20150822075310.GA2337@afzalpc>
References: <C21B8761-0447-45A6-B833-742E3B4C13DE@gmail.com>
 <55D5B3A9.6040901@ti.com>
 <867D66CD-9A3B-4536-B537-8C065C85E497@gmail.com>
 <55D6C812.6080400@ti.com>
 <4DCC50F3-9B6D-4A3A-9693-E7A7196564A8@gmail.com>
 <55D6DAE5.20304@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55D6DAE5.20304@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1076
Lines: 30

Hi,

On Fri, Aug 21, 2015 at 11:01:41AM +0300, Tomi Valkeinen wrote:

> >> Possibly the patches are still good for x86 also, but that needs to be
> >> proven.
> >>
> > not exactly, because x86_64 don’t have hardware instruction to do rbit OP,
> > i compile by test :
> 
> For old drivers i386 may be more relevant than x86_64.

It seems asm bit reversal is supported in Kernel on arm & arm64 only,
not sure whether any other arch even provide asm bit reversal
instruction.

> These kind of optimizations should have some real world measurements,

Not for this case, but once measured on ARM, iirc, a 32-bit asm bit
reversal as compared to doing it in C was taking 1 cycle as opposed to
~225 cycles!, of course writing optimized C could have made it fare
better, but still would reach no-way near asm bit reversal.

Regards
Afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/