Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbbHVNXs (ORCPT ); Sat, 22 Aug 2015 09:23:48 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:36124 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967AbbHVNXq (ORCPT ); Sat, 22 Aug 2015 09:23:46 -0400 Subject: Re: [PATCH v6 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller To: Chunfeng Yun , Mathias Nyman References: <1440207911-17666-1-git-send-email-chunfeng.yun@mediatek.com> <1440207911-17666-3-git-send-email-chunfeng.yun@mediatek.com> Cc: Rob Herring , Mark Rutland , Matthias Brugger , Felipe Balbi , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros , linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, John Crispin , Daniel Kurtz , Kishon Vijay Abraham I From: Sergei Shtylyov Message-ID: <55D877DD.3010400@cogentembedded.com> Date: Sat, 22 Aug 2015 16:23:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1440207911-17666-3-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2183 Lines: 66 Hello. On 8/22/2015 4:45 AM, Chunfeng Yun wrote: > add a DT binding documentation of xHCI host controller for the > MT8173 SoC from Mediatek. > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mt8173-xhci.txt | 52 ++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > new file mode 100644 > index 0000000..8e6e463 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > @@ -0,0 +1,52 @@ > +mt65XX xHCI The file is called mt8173-xhci.txt. Are you sure MT65xx should be here? > + > +The device node for Mediatek SOC usb3.0 host controller > + > +Required properties: > + - compatible : should contain "mediatek,mt8173-xhci" > + - reg : specifies physical base address and size of the registers, > + the first one for MAC, the second for IPPC > + - interrupts : interrupt used by the controller > + - power-domains : a phandle to USB power domain node to control usb's USB's -- be consistent, please. > + mtcmos > + - vusb33-supply : regulator of usb avdd3.3v > + > + - clocks : a list of phandle + clock-specifier pairs, one for each > + entry in clock-names > + - clock-names : must contain > + "sys_ck": for clock of xHCI MAC > + "wakeup_deb_p0": for usb wakeup debounce clock of port0 > + "wakeup_deb_p0": for usb wakeup debounce clock of port1 USB. > + > + - phys : a list of phandle + phy specifier pairs > + - usb3-lpm-capable : supports USB3 LPM > + - mediatek,syscon-wakeup : phandle to syscon used to access usb wakeup > + control register > + - mediatek,wakeup-src : 1: ip sleep wakeup mode; 2: line state wakeup > + mode; others means don't enable wakeup source of usb "Others mean" and "USB". [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/