Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbbHVOwH (ORCPT ); Sat, 22 Aug 2015 10:52:07 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:36122 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752568AbbHVOwF convert rfc822-to-8bit (ORCPT ); Sat, 22 Aug 2015 10:52:05 -0400 MIME-Version: 1.0 In-Reply-To: <55D51E1B.8090701@citrix.com> References: <1439990719-19517-1-git-send-email-mopsfelder@gmail.com> <55D51E1B.8090701@citrix.com> From: =?UTF-8?Q?Murilo_Opsfelder_Ara=C3=BAjo?= Date: Sat, 22 Aug 2015 11:51:24 -0300 Message-ID: Subject: Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() To: Julien Grall Cc: Linux Kernel Mailing List , xen-devel@lists.xenproject.org, Konrad Rzeszutek Wilk , Boris Ostrovsky , Stefano Stabellini , David Vrabel Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 45 On Wed, Aug 19, 2015 at 9:23 PM, Julien Grall wrote: > Hi, > > On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote: >> >> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use >> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to >> xen_tmem_get_page() receiving pfn instead of page. >> >> This change also fixes the following build warning: >> >> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’: >> drivers/xen/tmem.c:194:47: warning: passing argument 4 of >> ‘xen_tmem_get_page’ makes pointer from integer without a cast >> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn); >> ^ >> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is >> of type ‘long unsigned int’ >> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid, >> ^ >> >> Signed-off-by: Murilo Opsfelder Araujo > > > Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is not > enabled on my config. > > Reviewed-by: Julien Grall > > Regards, > > -- > Julien Grall Hi, Julien. No need to apologize, and thanks for reviewing that. -- Murilo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/