Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbbHVVZw (ORCPT ); Sat, 22 Aug 2015 17:25:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45909 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbbHVVZv (ORCPT ); Sat, 22 Aug 2015 17:25:51 -0400 Date: Sat, 22 Aug 2015 14:25:50 -0700 From: Luiz Capitulino To: Guenter Roeck Cc: Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed Message-ID: <20150822142550.254aec3a@redhat.com> In-Reply-To: <1440231047-16256-1-git-send-email-linux@roeck-us.net> References: <1440231047-16256-1-git-send-email-linux@roeck-us.net> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1446 Lines: 39 On Sat, 22 Aug 2015 01:10:47 -0700 Guenter Roeck wrote: > Commit 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()") > drops the return code of hrtimer_switch_to_hres(). While doing so, it also > drops the return statement itself on failure. This may cause a system hang. > Seen when running arm:multi_v7_defconfig in qemu with devicetree file > vexpress-v2p-ca9. > > Fixes: 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()") > Cc: Luiz Capitulino > Signed-off-by: Guenter Roeck Thanks for catching it Guenter! Reviewed-by: Luiz Capitulino > --- > kernel/time/hrtimer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c > index 5c4fe50e47d3..457a373e2181 100644 > --- a/kernel/time/hrtimer.c > +++ b/kernel/time/hrtimer.c > @@ -695,6 +695,7 @@ static void hrtimer_switch_to_hres(void) > if (tick_init_highres()) { > printk(KERN_WARNING "Could not switch to high resolution " > "mode on CPU %d\n", base->cpu); > + return; > } > base->hres_active = 1; > hrtimer_resolution = HIGH_RES_NSEC; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/