Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751755AbbHWIyP (ORCPT ); Sun, 23 Aug 2015 04:54:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42889 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbbHWIyM (ORCPT ); Sun, 23 Aug 2015 04:54:12 -0400 Message-ID: In-Reply-To: References: <1440079144-26461-1-git-send-email-ygardi@codeaurora.org> <1440079144-26461-8-git-send-email-ygardi@codeaurora.org> Date: Sun, 23 Aug 2015 08:54:11 -0000 Subject: Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus From: ygardi@codeaurora.org To: "Akinobu Mita" Cc: "Yaniv Gardi" , "Rob Herring" , "Jej B" , "Paul Bolle" , "Christoph Hellwig" , "LKML" , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, "Santosh Y" , linux-scsi-owner@vger.kernel.org, "Subhash Jadavani" , "Gilad Broner" , "Dolev Raviv" , "Vinayak Holikatti" , "James E.J. Bottomley" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1539 Lines: 44 > 2015-08-20 22:59 GMT+09:00 Yaniv Gardi : > >> +static bool ufs_qcom_testbus_cfg_is_ok(struct ufs_qcom_host *host) >> +{ >> + if (host->testbus.select_major >= TSTBUS_MAX) { >> + dev_err(host->hba->dev, >> + "%s: UFS_CFG1[TEST_BUS_SEL} may not equal >> 0x%05X\n", >> + __func__, host->testbus.select_major); >> + return false; >> + } >> + >> + /* >> + * Not performing check for each individual select_major >> + * mappings of select_minor, since there is no harm in >> + * configuring a non-existent select_minor >> + */ >> + if (host->testbus.select_major > 0x1F) { > > select_minor should be checked instead of select_major here? you are correct. should be select_minor > >> + dev_err(host->hba->dev, >> + "%s: 0x%05X is not a legal testbus option\n", >> + __func__, host->testbus.select_minor); >> + return false; >> + } >> + >> + return true; >> +} > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/