Message-ID: <1440356338.2670.9.camel@perches.com>
Subject: Re: [PATCH] usb: core: driver: Use kmalloc_array
From: Joe Perches <joe@perches.com>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Sun, 23 Aug 2015 11:58:58 -0700
In-Reply-To: <1440355729-20536-1-git-send-email-falakreyaz@gmail.com>
References: <1440355729-20536-1-git-send-email-falakreyaz@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1165
Lines: 31

On Mon, 2015-08-24 at 00:18 +0530, Muhammad Falak R Wani wrote:
> This patch introduces the use of function kmalloc_array(), instead
> of using kmalloc(), for allocating memory for an array and removes
> the corresponding call to kmalloc().
[]
> diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
[]
> @@ -416,7 +416,7 @@ static int usb_unbind_interface(struct device *dev)
>  		if (ep->streams == 0)
>  			continue;
>  		if (j == 0) {
> -			eps = kmalloc(USB_MAXENDPOINTS * sizeof(void *),
> +			eps = kmalloc_array(USB_MAXENDPOINTS, sizeof(void *),
>  				      GFP_KERNEL);
>  			if (!eps) {
>  				dev_warn(dev, "oom, leaking streams\n");

Allocations like this really don't need to use
kmalloc_array as it's unlikely that USB_MAXENDPOINTS
is very large.

If you are going to do this, it'd be nicer to keep
the parenthesis alignment and likely also better to
remove the dev_warn for a memory leak.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/