Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932199AbbHWX5J (ORCPT ); Sun, 23 Aug 2015 19:57:09 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:61773 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753463AbbHWX5H (ORCPT ); Sun, 23 Aug 2015 19:57:07 -0400 X-AuditID: cbfec7f5-f794b6d000001495-f3-55da5dcf4964 Message-id: <55DA5DCA.6080802@samsung.com> Date: Mon, 24 Aug 2015 08:56:58 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Joonyoung Shim , rtc-linux@googlegroups.com Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, alexandre.belloni@free-electrons.com, a.zummo@towertech.it, sbkim73@samsung.com Subject: Re: [PATCH v2] rtc: s5m: fix to update ctrl register References: <1440150221-2609-1-git-send-email-jy0922.shim@samsung.com> In-reply-to: <1440150221-2609-1-git-send-email-jy0922.shim@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsVy+t/xK7rnY2+FGjyaJ2yx5OJVdouOa4uZ LF7cu8hi8fqFocXlXXPYLGac38dksb+zg9Hi4oovTBYLNj5idOD0eLLpIqPHnokn2Tz6tqxi 9Jg+7yeTx+dNcgGsUVw2Kak5mWWpRfp2CVwZXZMfMha8F6z4ffgJYwPjVL4uRg4OCQETieOr uLsYOYFMMYkL99azgdhCAksZJba2KXYxcgHZXxglXj5YxQpSzyugJfFySRRIDYuAqsScnd2M IDabgLHE5uVLwHpFBSIklq8+CRbnFRCU+DH5HguILSLgIfFz0xs2kJnMAhsYJW48+sIMMlNY wFai52kixF43iauT3zCB2JwC7hL7Dk9mAylhFtCTuH9RCyTMLCAvsXnNW+YJjAKzkGyYhVA1 C0nVAkbmVYyiqaXJBcVJ6blGesWJucWleel6yfm5mxgh4f51B+PSY1aHGAU4GJV4eFeY3QoV Yk0sK67MPcQowcGsJMKr9PJmqBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGan phakFsFkmTg4pRoYb/Bo+WhqGS5qf/98qu8k0Wgtk2g5zvScDTncfRvdnz3z9bZKb4nbbJ33 T9rj75NG61yrX3eNsl4EhIuukeOMOnK/Us+vcHtRdu1Fwwk1D738E6zKW57V3zLvfXaM601A o6XhA41bL25OO/ns5p23V8XaOyL3Hd819/CmuKX5uR05sVf3Ck5QYinOSDTUYi4qTgQAY0XT a3MCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2465 Lines: 72 On 21.08.2015 18:43, Joonyoung Shim wrote: > According to datasheet, the S2MPS13X and S2MPS14X should update write > buffer via setting WUDR bit to high after ctrl register is written. > > If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use > tools/testing/selftests/timers/rtctest.c test program and hour format is > used to 12 hour mode in Odroid-XU3 board. > > One more issue is the RTC doesn't keep time on Odroid-XU3 board when i > turn on board after power off even if RTC battery is connected. It can > be solved as setting WUDR & RUDR bits to high at the same time after > RTC_CTRL register is written. It's same with condition of only writing > ALARM registers, so this is for only S2MPS14 and we should set WUDR & > A_UDR bits to high on S2MPS13. > > I can't find any reasonable description about this like fix from > datasheet, but can find similar codes from rtc driver source of > hardkernel kernel and vender kernel. s/vender/vendor/ > > Signed-off-by: Joonyoung Shim > Cc: # v3.16 > --- > Changelog for v2: > - update commit description and code to fix time keeping problem > - update the stable tag with the kernel version > > drivers/rtc/rtc-s5m.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c > index 8c70d78..646bf45 100644 > --- a/drivers/rtc/rtc-s5m.c > +++ b/drivers/rtc/rtc-s5m.c > @@ -635,6 +635,16 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) > case S2MPS13X: > data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); > ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); > + if (ret < 0) > + break; > + > + /* > + * Should set WUDR & (RUDR or AUDR) bits to high after writing > + * RTC_CTRL register like writing Alarm registers. We can't find > + * the description from datasheet but vender code does that s/vender/vendor/ > + * really. > + */ > + ret = s5m8767_rtc_set_alarm_reg(info); > break; > > default: > Reviewed-by: Krzysztof Kozlowski Tested on S2MPS14 and S2MPS11: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/