Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbbHXDcc (ORCPT ); Sun, 23 Aug 2015 23:32:32 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:51813 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbbHXDcb (ORCPT ); Sun, 23 Aug 2015 23:32:31 -0400 Message-ID: <55DA9045.2060107@roeck-us.net> Date: Sun, 23 Aug 2015 20:32:21 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Justin Chen , linux-kernel@vger.kernel.org CC: feedback-list@broadcom.com, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, wim@iguana.be, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation References: <1440092486-16905-1-git-send-email-justinpopo6@gmail.com> <1440092486-16905-2-git-send-email-justinpopo6@gmail.com> In-Reply-To: <1440092486-16905-2-git-send-email-justinpopo6@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1609 Lines: 52 Hi Justin, On 08/20/2015 10:41 AM, Justin Chen wrote: > Add device tree binding docmentation for the watchdog hardware block > on bcm7038 and newer SoCs. > > Signed-off-by: Justin Chen > --- > .../devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > new file mode 100644 > index 0000000..adb8260 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > @@ -0,0 +1,19 @@ > +BCM7038 Watchdog timer > + > +Required properties: > + > +- compatible : should be "brcm,bcm7038-wdt" > +- reg : Specifies base physical address and size of the registers. > + > +Optional properties: > + > +- clocks: the clock running the watchdog > +- clock-frequency: the rate of the clock Is 'clock-frequency' really needed (and useful), or would it make more sense to expect the user to configure a fixed clock if nothing else is available ? How do other drivers handle this ? Thanks, Guenter > + > +Example: > + > +watchdog { > + compatible = "brcm,bcm7038-wdt"; > + clocks = <&upg_fixed>; > + reg = <0xf040a7e8 0x16>; > +}; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/