MIME-Version: 1.0
In-Reply-To: <55D72A7C.1020101@fau.de>
References: <55D72A7C.1020101@fau.de>
From: Jianwei Wang <jianwei.wang.chn@gmail.com>
Date: Mon, 24 Aug 2015 12:10:21 +0800
Message-ID: <CANk3uyCGPgM6B8CAuaJbQGLgzKS_QeQqsKqwYzEHD2uNUKjQMQ@mail.gmail.com>
Subject: Re: drm/layerscape: Add Freescale DCU DRM driver
To: Andreas Ruprecht <andreas.ruprecht@fau.de>
Cc: linux-kernel@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch>,
        Xiubo Li <lixiubo@cmss.chinamobile.com>,
        Alison Wang <b18965@freescale.com>,
        Valentin Rothberg <valentinrothberg@gmail.com>,
        Stefan Hengelein <stefan.hengelein@fau.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1489
Lines: 45

Hi Andreas,

Sorry for the late reply. Yes, this driver should also work on the
arm64 SOCs using DCU in the future. So I did some prepare for adapting
arm64 SOCs. But for now, It only support 32bit arm SOCs.

Regards,

Jianwei.

On Fri, Aug 21, 2015 at 9:41 PM, Andreas Ruprecht
<andreas.ruprecht@fau.de> wrote:
> Hi Jianwei,
>
> your commit 109eee2f2a18 ("drm/layerscape: Add Freescale DCU DRM
> driver") showed up in linux-next today (i.e., next-20150821). I noticed
> it because we are running a daily analysis on the newest linux-next tree
> as part of our research.
>
> In the source code of fsl_dcu_drm_drv.c, there is the following #ifdef:
>  #ifdef CONFIG_COMPAT
>         .compat_ioctl   = drm_compat_ioctl,
>  #endif
>
> The Kconfig option for the driver, however, states that the driver can
> only be built with CONFIG_ARM enabled:
>
> config DRM_FSL_DCU
>        tristate "DRM Support for Freescale DCU"
>        depends on DRM && OF && ARM
>        [...]
>
> Inside arch/arm/, however, there is no definition of CONFIG_COMPAT (note
> that there is one in arch/arm64/, but the driver explicitely needs
> CONFIG_ARM), so the #ifdef block above can never be compiled in the
> current state. Is this intended?
>
> Regards,
>
> Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/