From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
To: Alan Stern <stern@rowland.harvard.edu>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "balbi@ti.com" <balbi@ti.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Li Leo <LeoLi@freescale.com>
Subject: RE: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb host
 driver
Thread-Topic: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb host
 driver
Thread-Index: AQHQ1fOLHEZ3GswMtUS/GfcJ3NrDb54KRRoAgAohELCAAJG0AIAFwn+g
Date: Mon, 24 Aug 2015 06:17:11 +0000
Message-ID: <SN1PR0301MB158367EE283A8734AA239A4DE0620@SN1PR0301MB1583.namprd03.prod.outlook.com>
References: <SN1PR0301MB15831315C12DA96B80F23E85E0660@SN1PR0301MB1583.namprd03.prod.outlook.com>
 <Pine.LNX.4.44L0.1508201008480.1272-100000@iolanthe.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.1508201008480.1272-100000@iolanthe.rowland.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2015 06:17:11.7925
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0733
X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1248;2:jEl+w4XWwAPCFZLB1AoO5P7l/z8spaqZQhCXsVvwYQHY0uLsNNBdpAQ7ymOVF020qU+p7qyPSteOBNOKORweQfQYzAVV0K18VQcMC4QZaLmWpMutNWk7Jr9W2EOFZW3vB9yT4uyEB22VcDG6z8JucM3iPtLrmjFYxm/24ITLlOY=;3:w/8Twg4/IbH3I7DCgpxfj13sLgkdC6U1awiKPC2/x75eSKiQZJrTLqZTAsTi126n08dL/EU+74jK3jWJbKzppjwhyAe0eNHftLmSDlyzAegymaB5IV6Chdf+SNoMvzwbkMReMAqP6dPZrzB5cyspGg==;25:K0Iq+ZLkzLOEWoIzh2L913oOSieCAs635igss55T953JJ21ITXKfPkarosSo81nlw6RZ0u7iF+sGYI23iSNt0Mxp15Rl3oaYLtefE8c9Ybzjj4r8P11P2reOB48imHFYIa1iAQuBHxGq/7mIulKmnhqQ9FY00IYg9ufrWwC4a70Kx0Pa192EUH2HspFkC3IgzSxjkqZV+/3m+9SwQr9lzxCG6eT2vUOzEF845kfO22m5ygWF9KmodJXrmpnbtcna;23:Z8VICngfeiChL9rekvLoakPRxWuHTpHbvGdepsGuGbYZa0uG4XdHwQLAgZE2V4i7zkNOQjEbHHoQuUVD/F81fDJchy0zqocSU5Bj4WCRyUwCn/OftdX6FUBYWxwwxmnMS9Nf1V/rmC5YVnDnBp19GCNQyBLL5OjEZ244P+DdkJHHp2OxsNM4Ux1JagS6bsP6
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2109
Lines: 53


> -----Original Message-----
> From: Alan Stern [mailto:stern@rowland.harvard.edu]
> Sent: Thursday, August 20, 2015 7:40 PM
> To: Mehresh Ramneek-B31383 <ramneek.mehresh@freescale.com>
> Cc: linux-kernel@vger.kernel.org; balbi@ti.com;
> gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; Li Yang-Leo-R58472
> <LeoLi@freescale.com>
> Subject: RE: [PATCH 3/8][v3]usb:fsl:otg: Add support to add/remove usb
> host driver
> 
> On Thu, 20 Aug 2015, Ramneek Mehresh wrote:
> 
> > > > --- a/drivers/usb/host/ehci-fsl.h
> > > > +++ b/drivers/usb/host/ehci-fsl.h
> > > > @@ -63,4 +63,22 @@
> > > >  #define UTMI_PHY_EN             (1<<9)
> > > >  #define ULPI_PHY_CLK_SEL        (1<<10)
> > > >  #define PHY_CLK_VALID		(1<<17)
> > > > +
> > > > +struct ehci_fsl {
> > > > +#ifdef CONFIG_PM
> > > > +	/* Saved USB PHY settings, need to restore after deep sleep. */
> > > > +	u32 usb_ctrl;
> > > > +#endif
> > >
> > > Do you need this #ifdef?
> > >
> > Yes, this is required for deep-sleep support...we need to save/restore
> controller
> > registers during deep-sleep when usb controller power is shut-off. Don't
> need this
> > during normal usb operation...saving/restoring usb controller registers in
> non deep-sleep
> > scenario will add unnecessary delays
> 
> What I meant was, can you keep the "u32 usb_ctrl;" line but get rid of
> the "#ifdef CONFIG_PM" and "#endif" lines?
> 
> Alan Stern
I do understand that. However, USB suspend/resume functionality work in context of
PM. Only in this context, we need to save/restore usb controller register
for deep-sleep functionality. If you see usage of this in ehci-fsl.c file, it's used in 
ehci_fsl_drv_suspend() under CONFIG_PM to save USB CNTL register.
If I remove CONFIG_PM from struct ehci_fsl{}, I'll need to change the entire driver
also to make suspend and resume functionalities compile by default.
   
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/