Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932397AbbHXIUb (ORCPT ); Mon, 24 Aug 2015 04:20:31 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:17251 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbbHXIUa (ORCPT ); Mon, 24 Aug 2015 04:20:30 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-0e-55dad3cc0fd8 Message-id: <55DAD3CB.5060705@samsung.com> Date: Mon, 24 Aug 2015 10:20:27 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Bjorn Andersson Cc: Bryan Wu , Richard Purdie , Linus Walleij , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: syscon: Correct check for syscon_node_to_regmap() errors References: <1439925926-3174-1-git-send-email-bjorn.andersson@sonymobile.com> In-reply-to: <1439925926-3174-1-git-send-email-bjorn.andersson@sonymobile.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsVy+t/xa7pnLt8KNdj1lcPiR9N8JoujOycy WUz5s5zJ4vKuOWwWW9+sY7TYvespqwObx85Zd9k97lzbw+axZ/4PVo87B26zenzeJBfAGsVl k5Kak1mWWqRvl8CVsXTWRvaCI+wVyx4uZ2tgbGfrYuTkkBAwkVj6ewULhC0mceHeeqA4F4eQ wFJGiZWtj1ggnGeMElsX32HqYuTg4BXQkjj0KBakgUVAVeL104nMIDabgKHEzxevmUBsUYEI iT+n97GC2LwCghI/Jt8DWyACtGz61GmMIDOZBdYySjx7t4UdZKYwUMOiSSEgNUICvhK9t9aD Hccp4Cfx+NpZdhCbWcBaYuWkbYwQtrzE5jVvmScwCsxCsmIWkrJZSMoWMDKvYhRNLU0uKE5K zzXUK07MLS7NS9dLzs/dxAgJ7S87GBcfszrEKMDBqMTDy2B5K1SINbGsuDL3EKMEB7OSCK/S y5uhQrwpiZVVqUX58UWlOanFhxilOViUxHnn7nofIiSQnliSmp2aWpBaBJNl4uCUamC0WPv9 9OlLXF+9j80UNFP2/LZqoufP69skGivvqicsb5g1M91Ezc/m/X+B44m7HjysYDhstI7nO1/T mcSMWr/AaTJKZaEe8+bcuVQq9jVxx/dDXXfexSw7qzlvg1/m0fuLQt5qVf5+fPu8yjTfmswd U5uFftxyVJ+jZFxwkXdNxl+ezRX8s7atVmIpzkg01GIuKk4EACTYAFVpAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 40 On 08/18/2015 09:25 PM, Bjorn Andersson wrote: > syscon_node_to_regmap() returns a regmap or an ERR_PTR(). > > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - Propagate the error > > drivers/leds/leds-syscon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c > index d1660b039812..b88900d721e4 100644 > --- a/drivers/leds/leds-syscon.c > +++ b/drivers/leds/leds-syscon.c > @@ -83,9 +83,9 @@ static int syscon_led_probe(struct platform_device *pdev) > return -ENODEV; > } > map = syscon_node_to_regmap(parent->of_node); > - if (!map) { > + if (IS_ERR(map)) { > dev_err(dev, "no regmap for syscon LED parent\n"); > - return -ENODEV; > + return PTR_ERR(map); > } > > sled = devm_kzalloc(dev, sizeof(*sled), GFP_KERNEL); > Merged, thanks. -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/