Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932631AbbHXIeP (ORCPT ); Mon, 24 Aug 2015 04:34:15 -0400 Received: from mail-by2on0113.outbound.protection.outlook.com ([207.46.100.113]:57021 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751475AbbHXIeK (ORCPT ); Mon, 24 Aug 2015 04:34:10 -0400 From: Chen Bough To: Markus Pargmann CC: "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , "linux@arm.linux.org.uk" , "dmitry.torokhov@gmail.com" , "devicetree@vger.kernel.org" , "sbranden@broadcom.com" , "arnd@arndb.de" , "mchehab@osg.samsung.com" , "christian.gmeiner@gmail.com" , "scott.liu@emc.com.tw" , "linux-kernel@vger.kernel.org" , "hdegoede@redhat.com" , "jonathar@broadcom.com" , "benjamin.tissoires@redhat.com" , "hans.verkuil@cisco.com" , "hadess@hadess.net" , "linux-input@vger.kernel.org" , "geert@linux-m68k.org" , "sebastien.szymanski@armadeus.com" , "mamlinav@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc Thread-Topic: [PATCH v2 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc Thread-Index: AQHQyRugDYZbjzbCYkaq5LD/KCcxYZ4S9NQAgANKRdCAABXdgIAEpdvg Date: Mon, 24 Aug 2015 08:34:07 +0000 Message-ID: References: <1438077521-12857-1-git-send-email-haibo.chen@freescale.com> <1438077521-12857-3-git-send-email-haibo.chen@freescale.com> <20150819055434.GF11161@pengutronix.de> <20150821092725.GB706@pengutronix.de> In-Reply-To: <20150821092725.GB706@pengutronix.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Haibo.Chen@freescale.com; x-originating-ip: [123.151.195.52] x-microsoft-exchange-diagnostics: 1;BY1PR03MB1385;5:dOHkeJwSznQh/1yHS6VXa9b8EgA1hOGN4xAc6puyKmOkRvVaug8RZc9HV8ukUct+LGCHv/ZdSHoyBbJgUFP1S8asHLsGAbUlG5OlBWkL2DWd2mGHSYddiplm2cxdnQ0K9zhQr7EdiZ4l1piL4n7IKA==;24:zRHeQNFNicBQL+mceToV9j9TxWfy+7R+723O30AUQsUofMhub2KRq7vGLJv08YyAKGYrZHJ3xXI9k2ZQWp0UNul5ajlwe3RrViTKAfl+i/E=;20:f4NkLI9EIMzn05fq10h1rfQmK5Uxo6UJd92EoAYv7Xe3Y9oRx6eNWmOvpy3BnZAVDlLg9FIDxREEbpIjZzGwtA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1385; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BY1PR03MB1385;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1385; x-forefront-prvs: 06780E24F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(24454002)(13464003)(199003)(377454003)(105586002)(46102003)(50986999)(5002640100001)(102836002)(99286002)(101416001)(2656002)(76176999)(54356999)(15975445007)(77096005)(92566002)(5004730100002)(33656002)(66066001)(2950100001)(5007970100001)(5003600100002)(106116001)(106356001)(93886004)(2900100001)(86362001)(77156002)(76576001)(122556002)(64706001)(62966003)(19580395003)(81156007)(68736005)(19580405001)(5001830100001)(74316001)(97736004)(4001540100001)(5001860100001)(189998001)(5001960100002)(5001920100001)(10400500002)(110136002)(40100003)(87936001)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1385;H:BY1PR03MB1388.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2015 08:34:07.5966 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1385 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7O8YJrU009100 Content-Length: 6703 Lines: 181 > -----Original Message----- > From: Markus Pargmann [mailto:mpa@pengutronix.de] > Sent: Friday, August 21, 2015 5:27 PM > To: Chen Haibo-B51421 > Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com; > ijc+devicetree@hellion.org.uk; galak@codeaurora.org; shawnguo@kernel.org; > kernel@pengutronix.de; linux@arm.linux.org.uk; dmitry.torokhov@gmail.com; > devicetree@vger.kernel.org; sbranden@broadcom.com; arnd@arndb.de; > mchehab@osg.samsung.com; christian.gmeiner@gmail.com; > scott.liu@emc.com.tw; linux-kernel@vger.kernel.org; hdegoede@redhat.com; > jonathar@broadcom.com; benjamin.tissoires@redhat.com; > hans.verkuil@cisco.com; hadess@hadess.net; linux-input@vger.kernel.org; > geert@linux-m68k.org; sebastien.szymanski@armadeus.com; > mamlinav@gmail.com; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2 2/5] Documentation: Detail permitted DT properties > for the imx6ul_tsc > > On Fri, Aug 21, 2015 at 08:30:16AM +0000, Chen Bough wrote: > > Hi Markus, > > > > > -----Original Message----- > > > From: Markus Pargmann [mailto:mpa@pengutronix.de] > > > Sent: Wednesday, August 19, 2015 1:55 PM > > > To: Chen Haibo-B51421 > > > Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com; > > > ijc+devicetree@hellion.org.uk; galak@codeaurora.org; > > > ijc+shawnguo@kernel.org; > > > kernel@pengutronix.de; linux@arm.linux.org.uk; > > > dmitry.torokhov@gmail.com; devicetree@vger.kernel.org; > > > sbranden@broadcom.com; arnd@arndb.de; mchehab@osg.samsung.com; > > > christian.gmeiner@gmail.com; scott.liu@emc.com.tw; > > > linux-kernel@vger.kernel.org; hdegoede@redhat.com; > > > jonathar@broadcom.com; benjamin.tissoires@redhat.com; > > > hans.verkuil@cisco.com; hadess@hadess.net; > > > linux-input@vger.kernel.org; geert@linux-m68k.org; > > > sebastien.szymanski@armadeus.com; mamlinav@gmail.com; > > > linux-arm-kernel@lists.infradead.org > > > Subject: Re: [PATCH v2 2/5] Documentation: Detail permitted DT > > > properties for the imx6ul_tsc > > > > > > Hi, > > > > > > On Tue, Jul 28, 2015 at 05:58:38PM +0800, Haibo Chen wrote: > > > > Here we apply required documentation for the imx6ul touch screen > > > > controller driver which describe available properties and how to > > > > use them. > > > > > > > > Signed-off-by: Haibo Chen > > > > --- > > > > .../bindings/input/touchscreen/imx6ul_tsc.txt | 36 > > > ++++++++++++++++++++++ > > > > 1 file changed, 36 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.t > > > > xt > > > > b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.t > > > > xt > > > > new file mode 100644 > > > > index 0000000..ac41c32 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_t > > > > +++ sc.t > > > > +++ xt > > > > @@ -0,0 +1,36 @@ > > > > +* Freescale i.MX6UL Touch Controller > > > > + > > > > +Required properties: > > > > +- compatible: must be "fsl,imx6ul-tsc". > > > > +- reg: this touch controller address and the ADC2 address. > > > > > > This suggests that this driver is using a unit ADC2. Which also > > > means that there are more than one ADC which are probably identical? > > > > > > Shouldn't these ADCs be properly described by their own device nodes > > > instead of these two register ranges, two interrupts and two clocks? > > > > > > Is 'ADC2' usable without tsc? Then ADC1/ADC2 should perhaps get a > > > proper IIO driver. > > > > For i.MX6UL, there are two ADC. ADC1 is a normal ADC, and ADC2 can > > only works for TSC, the channels of ADC2 are connected to TSC > > directly. TSC and ADC2 should work together as a touch screen > controller. > > But as I understand these are two different units. Wouldn't it be better > to abstract it that way in the DT? Since the ADC2 just work for TSC, no other use, why not bind ADC2 and TSC? If separate, seems ADC2 can works as a normal ADC, but actually it can't. Best regards, Haibo > > Best regards, > > Markus > > > > > For ADC1, it share the driver vf610_adc.c (drivers/iio/adc/vf610_adc.c). > > > > Best Regards > > > > Haibo > > > > > > > > Unfortunately I don't have the reference manual to have a look how > > > this all works. > > > > > > Best regards, > > > > > > Markus > > > > > > > +- interrupts: the interrupt of this touch controller and ADC2. > > > > +- clocks: the root clock of touch controller and ADC2. > > > > +- clock-names; must be "tsc" and "adc". > > > > +- xnur-gpio: the X- gpio this controller connect to. > > > > + This xnur-gpio returns to high once the finger leave the touch > > > > +screen (The > > > > + last touch event the touch controller capture). > > > > + > > > > +Optional properties: > > > > +- measure-delay-time: the value of measure delay time. > > > > + Before X-axis or Y-axis measurement, the screen need some time > > > > +before > > > > + even potential distribution ready. > > > > + This value depends on the touch screen. > > > > +- pre-charge-time: the touch screen need some time to precharge. > > > > + This value depends on the touch screen. > > > > + > > > > +Example: > > > > + tsc: tsc@02040000 { > > > > + compatible = "fsl,imx6ul-tsc"; > > > > + reg = <0x02040000 0x4000>, <0x0219c000 0x4000>; > > > > + interrupts = , > > > > + ; > > > > + clocks = <&clks IMX6UL_CLK_IPG>, > > > > + <&clks IMX6UL_CLK_ADC2>; > > > > + clock-names = "tsc", "adc"; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_tsc>; > > > > + xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>; > > > > + measure-delay-time = <0xfff>; > > > > + pre-charge-time = <0xffff>; > > > > + status = "okay"; > > > > + }; > > > > -- > > > > 1.9.1 > > > > > > > > > > > > > > > > > > -- > > > Pengutronix e.K. | > > > | > > > Industrial Linux Solutions | > http://www.pengutronix.de/ > > > | > > > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: > > > +49-5121-206917-0 > > > | > > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- > 5555 > > > | > > -- > Pengutronix e.K. | > | > Industrial Linux Solutions | http://www.pengutronix.de/ > | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 > | ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?