Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933850AbbHXJgQ (ORCPT ); Mon, 24 Aug 2015 05:36:16 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37446 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932572AbbHXJgK (ORCPT ); Mon, 24 Aug 2015 05:36:10 -0400 Date: Mon, 24 Aug 2015 12:36:07 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , Mel Gorman , Andrea Arcangeli , Dave Hansen , Vlastimil Babka , Johannes Weiner , Michal Hocko , David Rientjes , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv3 0/5] Fix compound_head() race Message-ID: <20150824093607.GB1994@node.dhcp.inet.fi> References: <1439976106-137226-1-git-send-email-kirill.shutemov@linux.intel.com> <20150820123107.GA31768@node.dhcp.inet.fi> <20150820163836.b3b69f2bf36dba7020bdc893@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 20 On Sat, Aug 22, 2015 at 01:13:19PM -0700, Hugh Dickins wrote: > Yes, I did think the compound destructor enum stuff over-engineered, > and would have preferred just direct calls to free_compound_page() > or free_huge_page() myself. But when I tried to make a patch on > top to do that, even when I left PageHuge out-of-line (which had > certainly not been my intention), it still generated more kernel > text than Kirill's enum version (maybe his "- 1" in compound_head > works better in some places than masking out 3, I didn't study); > so let's forget about that. I had my agenda on ->compound_dtor: my refcounting patchset introduces one more compound destructor. I wanted to avoid hardcoding them here. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/