Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932734AbbHXKBG (ORCPT ); Mon, 24 Aug 2015 06:01:06 -0400 Received: from foss.arm.com ([217.140.101.70]:36568 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753953AbbHXKBD (ORCPT ); Mon, 24 Aug 2015 06:01:03 -0400 Date: Mon, 24 Aug 2015 11:00:54 +0100 From: Mark Rutland To: Leo Yan Cc: Rob Herring , Pawel Moll , Ian Campbell , "galak@codeaurora.org" , Catalin Marinas , Will Deacon , Jassi Brar , Bintian Wang , "haojian.zhuang@linaro.org" , Yiping Xu , Wei Xu , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "guodong.xu@linaro.org" , Jian Zhang , Zhenwei Wang , Haoju Mo , Dan Zhao , "kongfei@hisilicon.com" , Guangyue Zeng Subject: Re: [PATCH v2 3/3] arm64: dts: add Hi6220 mailbox node Message-ID: <20150824100054.GB7139@leverpostej> References: <1440039239-8772-1-git-send-email-leo.yan@linaro.org> <1440039239-8772-4-git-send-email-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440039239-8772-4-git-send-email-leo.yan@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2016 Lines: 64 On Thu, Aug 20, 2015 at 03:53:59AM +0100, Leo Yan wrote: > On Hi6220, below memory regions in DDR have specific purpose: > > 0x05e0,0000 - 0x05ef,ffff: For MCU firmware using at runtime; > 0x0740,f000 - 0x0740,ffff: For MCU firmware's section; > 0x06df,f000 - 0x06df,ffff: For mailbox message data. > > This patch reserves these memory regions and add device node for > mailbox in dts. > > Signed-off-by: Leo Yan > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 20 +++++++++++++++++--- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++++++ > 2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index e36a539..d5470d3 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -7,9 +7,6 @@ > > /dts-v1/; > > -/*Reserved 1MB memory for MCU*/ > -/memreserve/ 0x05e00000 0x00100000; > - > #include "hi6220.dtsi" > > / { > @@ -28,4 +25,21 @@ > device_type = "memory"; > reg = <0x0 0x0 0x0 0x40000000>; > }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + mcu-buf@05e00000 { > + no-map; > + reg = <0x0 0x05e00000 0x0 0x00100000>, /* MCU firmware buffer */ > + <0x0 0x0740f000 0x0 0x00001000>; /* MCU firmware section */ > + }; > + > + mbox-buf@06dff000 { > + no-map; > + reg = <0x0 0x06dff000 0x0 0x00001000>; /* Mailbox message buf */ > + }; > + }; > }; As mentioned in my other reply [1], you should fix your EFI memory map instead. There is no reason for this at all. Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/365921.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/