Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754123AbbHXKoM (ORCPT ); Mon, 24 Aug 2015 06:44:12 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:34370 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbbHXKoL (ORCPT ); Mon, 24 Aug 2015 06:44:11 -0400 Date: Mon, 24 Aug 2015 12:44:08 +0200 From: Michal Hocko To: Yaowei Bai Cc: akpm@linux-foundation.org, mgorman@suse.de, vbabka@suse.cz, js1304@gmail.com, hannes@cmpxchg.org, alexander.h.duyck@redhat.com, sasha.levin@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment Message-ID: <20150824104408.GI17078@dhcp22.suse.cz> References: <1440229212-8737-1-git-send-email-bywxiaobai@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440229212-8737-1-git-send-email-bywxiaobai@163.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1829 Lines: 47 On Sat 22-08-15 15:40:10, Yaowei Bai wrote: > The comment says that the per-cpu batchsize and zone watermarks > are determined by present_pages which is definitely wrong, they > are both calculated from managed_pages. Fix it. This seems to be missed in b40da04946aa ("mm: use zone->present_pages instead of zone->managed_pages where appropriate") > > Signed-off-by: Yaowei Bai Acked-by: Michal Hocko > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 5b5240b..c22b133 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6003,7 +6003,7 @@ void __init mem_init_print_info(const char *str) > * set_dma_reserve - set the specified number of pages reserved in the first zone > * @new_dma_reserve: The number of pages to mark reserved > * > - * The per-cpu batchsize and zone watermarks are determined by present_pages. > + * The per-cpu batchsize and zone watermarks are determined by managed_pages. > * In the DMA zone, a significant percentage may be consumed by kernel image > * and other unfreeable allocations which can skew the watermarks badly. This > * function may optionally be used to account for unfreeable pages in the > -- > 1.9.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/