Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754226AbbHXLJ0 (ORCPT ); Mon, 24 Aug 2015 07:09:26 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:47688 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbbHXLJY convert rfc822-to-8bit (ORCPT ); Mon, 24 Aug 2015 07:09:24 -0400 Message-Id: <55DB1780020000780009CA7D@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.0.1 Date: Mon, 24 Aug 2015 05:09:20 -0600 From: "Jan Beulich" To: "Alexander Kuleshov" Cc: "Andy Lutomirski" , , "Thomas Gleixner" , "Denys Vlasenko" , "Ingo Molnar" , , "H. Peter Anvin" Subject: Re: [PATCH] x86/calling.h: remove unused SAVE_ALL/RESTORE_ALL macro for !CONFIG_x86_64 References: <1440184368-26602-1-git-send-email-kuleshovmail@gmail.com> In-Reply-To: <1440184368-26602-1-git-send-email-kuleshovmail@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1220 Lines: 31 >>> On 21.08.15 at 21:12, wrote: > SAVE_ALL and RESTORE_ALL macros for !CONFIG_X86_64 were introduced in the > 1a338ac32 commit (sched, x86: Optimize the preempt_schedule() call) and > were used in the ___preempt_schedule and ___preempt_schedule_context from > the arch/x86/kernel/preempt.S. But the arch/x86/kernel/preempt.S was > removed in the 0ad6e3c5 commit (x86: Speed up ___preempt_schedule*() by > using THUNK helpers) and ___preempt_schedule/___preempt_schedule_context > are reimplemeted and not used SAVE_ALL/RESTORE_ALL anymore. > > These macros have no users anymore, so we can remove it. As far as the description goes this is fine, but ... > --- a/arch/x86/entry/calling.h > +++ b/arch/x86/entry/calling.h > @@ -46,8 +46,6 @@ For 32-bit we have the following conventions - kernel is built with > > */ > > -#ifdef CONFIG_X86_64 ... why do you remove this conditional, thus exposing x86-64-only definitions to ix86 code? Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/