Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932780AbbHXMGL (ORCPT ); Mon, 24 Aug 2015 08:06:11 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:32809 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbbHXMGI (ORCPT ); Mon, 24 Aug 2015 08:06:08 -0400 Date: Mon, 24 Aug 2015 14:06:04 +0200 From: Michal Hocko To: "Theodore Ts'o" Cc: Greg Thelen , LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Johannes Weiner , Tetsuo Handa , Dave Chinner , linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, Jan Kara Subject: Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of frozen_buffer allocation failure Message-ID: <20150824120604.GM17078@dhcp22.suse.cz> References: <1438768284-30927-1-git-send-email-mhocko@kernel.org> <1438768284-30927-5-git-send-email-mhocko@kernel.org> <20150812091411.GB14940@dhcp22.suse.cz> <20150815135422.GA2976@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150815135422.GA2976@thunk.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 24 Hi Ted, On Sat 15-08-15 09:54:22, Theodore Ts'o wrote: > On Wed, Aug 12, 2015 at 11:14:11AM +0200, Michal Hocko wrote: > > > Is this "if (!committed_data) {" check now dead code? > > > > > > I also see other similar suspected dead sites in the rest of the series. > > > > You are absolutely right. I have updated the patches. > > Have you sent out an updated version of these patches? Maybe I missed > it, but I don't think I saw them. would you be interested in these two patches sent with rephrased changelog to not depend on the patch which allows GFP_NOFS to fail? The way this has been handled for btrfs... -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/