Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754469AbbHXMt5 (ORCPT ); Mon, 24 Aug 2015 08:49:57 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:52686 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754440AbbHXMtx (ORCPT ); Mon, 24 Aug 2015 08:49:53 -0400 Date: Mon, 24 Aug 2015 13:49:24 +0100 From: Russell King - ARM Linux To: Marek Vasut Cc: Cyrille Pitchen , mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, ben@decadent.org.uk, zajec5@gmail.com, nicolas.ferre@atmel.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-spi@vger.kernel.org, juhosg@openwrt.org, broonie@kernel.org, linux-mtd@lists.infradead.org, galak@codeaurora.org, shijie.huang@intel.com, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Subject: Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller Message-ID: <20150824124924.GZ7557@n2100.arm.linux.org.uk> References: <201508241303.52066.marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201508241303.52066.marex@denx.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 24 On Mon, Aug 24, 2015 at 01:03:51PM +0200, Marek Vasut wrote: > These are functions, not macros :) > > btw is there any reason for these ? I'd say, just put the read*() and > write*() functions directly into the code and be done with it, it is > much less confusing. > > Also, why do you use the _relaxed() versions of the functions ? Now that the _relaxed() accessors are available throughout the kernel, everyone should be using the _relaxed() versions unless they need the properties of the non-relaxed versions. Remember that the non-relaxed versions are rather expensive on ARM due to the need to go all the way out to the L2 cache - it at least doubles the number of accesses for every read*/write*(). -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/