Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754379AbbHXNCM (ORCPT ); Mon, 24 Aug 2015 09:02:12 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:32845 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbbHXNCJ (ORCPT ); Mon, 24 Aug 2015 09:02:09 -0400 Date: Mon, 24 Aug 2015 14:02:05 +0100 From: Lee Jones To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, devicetree@vger.kernel.org, k.kozlowski@samsung.com, broonie@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable Message-ID: <20150824130205.GE3237@x1> References: <1440420006-31556-1-git-send-email-vaibhav.hiremath@linaro.org> <1440420006-31556-2-git-send-email-vaibhav.hiremath@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440420006-31556-2-git-send-email-vaibhav.hiremath@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1857 Lines: 48 On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: > 88PM860 family of device supports dual phase mode on BUCK1 supply > providing total 6A capacity. > Note that by default they operate independently with 3A capacity. > > This patch updates the devicetree binding with DT property > to enable dual-phase mode on BUCK1. > > Signed-off-by: Vaibhav Hiremath > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > index dec842f..2c82fcb 100644 > --- a/Documentation/devicetree/bindings/mfd/88pm800.txt > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -9,6 +9,12 @@ Required parent device properties: > - #interrupt-cells : should be 1. > The cell is the 88pm80x local IRQ number > > +Optional properties : > +- marvell,88pm860-buck1-dualphase-en : If set, enable dual phase on BUCK1, > + providing 6A capacity. > + Without this both BUCK1A and BUCK1B operates independently with 3A capacity. > + (This property is only applicable to 88PM860) This will require a Regulator Ack. My suggestion would be to remove the 'buck' number, as the same property could be used on any Buck, and remove the '-en' part, as this is implied. > 88pm80x family of devices consists of varied group of sub-devices: > > Device Supply Names Description -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/