Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754533AbbHXNCj (ORCPT ); Mon, 24 Aug 2015 09:02:39 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:37580 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754458AbbHXNCh (ORCPT ); Mon, 24 Aug 2015 09:02:37 -0400 Message-ID: <55DB15EB.3090109@imgtec.com> Date: Mon, 24 Aug 2015 14:02:35 +0100 From: Qais Yousef User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Thomas Gleixner CC: , Jason Cooper , "Marc Zyngier" , , Subject: Re: [PATCH 01/10] irqchip: irq-mips-gic: export gic_send_ipi References: <1440419959-14315-1-git-send-email-qais.yousef@imgtec.com> <1440419959-14315-2-git-send-email-qais.yousef@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 34 On 08/24/2015 01:49 PM, Thomas Gleixner wrote: > On Mon, 24 Aug 2015, Qais Yousef wrote: > >> Some drivers might require to send ipi to other cores. So export it. > Which IPIs do you need to send from a driver which are not exposed by > the SMP functions already? It's not an SMP IPI. We use GIC to exchange interrupts between AXD and the host system since AXD is another MIPS core in the cluster. >> This will be used later by AXD driver. > That smells fishy and it wants a proper explanation WHY and not just a > sloppy statement that it will be used later. I can figure that out > myself as exporting a function without using it does not make any sense. Sorry for the terse explanation. As pointed above AXD uses GIC to send and receive interrupts to the host core. Without this change I can't compile the driver as a driver module because the symbol is not exported. Does this make things clearer? Thanks, Qais > > Thanks, > > tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/