Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754327AbbHXNGZ (ORCPT ); Mon, 24 Aug 2015 09:06:25 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33210 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbbHXNGY (ORCPT ); Mon, 24 Aug 2015 09:06:24 -0400 Date: Mon, 24 Aug 2015 18:36:16 +0530 From: Sudip Mukherjee To: Aparna Karuthodi Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, noralf@tronnes.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: Removed space before parenthesis Message-ID: <20150824130616.GD10585@sudip-pc> References: <1440079019-9997-1-git-send-email-kdasaparna@gmail.com> <1440171347-12894-1-git-send-email-kdasaparna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440171347-12894-1-git-send-email-kdasaparna@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 37 On Fri, Aug 21, 2015 at 09:05:47PM +0530, Aparna Karuthodi wrote: > Removed space before parenthesis in two different lines to remove coding > style errors detected by checkpatch. > The errors are given below: > drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before > that close parenthesis ')' > drivers/staging/fbtft/fbtft-bus.c:75: ERROR: space prohibited before > that close parenthesis ')' > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/fbtft/fbtft-bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c > index b3cddb0..791fab3 100644 > --- a/drivers/staging/fbtft/fbtft-bus.c > +++ b/drivers/staging/fbtft/fbtft-bus.c > @@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...) \ > } \ > EXPORT_SYMBOL(func); > > -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ) > +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8) > define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16) > -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, ) > +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16) Did you build test it? You have removed ',' while removing the space and that breaks the build. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/