Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754685AbbHXN0m (ORCPT ); Mon, 24 Aug 2015 09:26:42 -0400 Received: from foss.arm.com ([217.140.101.70]:37195 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754666AbbHXN0k (ORCPT ); Mon, 24 Aug 2015 09:26:40 -0400 Date: Mon, 24 Aug 2015 14:26:33 +0100 From: Mark Rutland To: Qais Yousef Cc: "alsa-devel@alsa-project.org" , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 02/10] dt: add img,axd.txt device tree binding document Message-ID: <20150824132633.GF7139@leverpostej> References: <1440419959-14315-1-git-send-email-qais.yousef@imgtec.com> <1440419959-14315-3-git-send-email-qais.yousef@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440419959-14315-3-git-send-email-qais.yousef@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2703 Lines: 84 On Mon, Aug 24, 2015 at 01:39:11PM +0100, Qais Yousef wrote: > Signed-off-by: Qais Yousef > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > .../devicetree/bindings/sound/img,axd.txt | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/img,axd.txt > > diff --git a/Documentation/devicetree/bindings/sound/img,axd.txt b/Documentation/devicetree/bindings/sound/img,axd.txt > new file mode 100644 > index 000000000000..6a8764a79d01 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/img,axd.txt > @@ -0,0 +1,34 @@ > +* AXD Audio Processing IP Binding * > + > +Required properties: > +- compatible: "img,axd" This sounds awfully generic. Is there not a more complete name? > +- clocks: phandle for the clock that drives AXD. > +- interrupts: the GIC interrupt where AXD is connected > +- gic-irq: it takes two non-zero values, the first one is the host hwirq and > + the second one is AXD's. Host's hwirq should match the value in > + interrupts. I don't understand what this gic-irq property is for; and it generally doesn't look right. Could you please describe what this is and why you thing it is necessary? > + > +Optional properties: > +- vpe: VPE number on which AXD should start. Must be provided if AXD is > + running as a single VPE along Linux on the same core. > + It can't be VPE0. > + The VPE will be offlined before AXD is loaded. Likewise could you please elaborate on this is? What is a VPE number? What does it mean to start at that number? > +- inbuf-size: size of shared input buffers area. By default it's 0x7800 bytes. > +- outbuf-size: size of shared output buffers area. By default it's 0x3c000 bytes. Is this something the kernel dynamically allocates? Why does this need to be in the DT? Thanks, Mark. > + > + > +Example: > + > + axdclk: axdclk@400M { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <400000000>; > + }; > + > + axd { > + compatible = "img,axd"; > + clocks = <&axdclk>; > + interrupts = <36 IRQ_TYPE_EDGE_RISING>; > + gic-irq = <36 37>; > + vpe = <1>; > + }; > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/