Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754840AbbHXOWQ (ORCPT ); Mon, 24 Aug 2015 10:22:16 -0400 Received: from mga11.intel.com ([192.55.52.93]:2754 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754119AbbHXOWM convert rfc822-to-8bit (ORCPT ); Mon, 24 Aug 2015 10:22:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,738,1432623600"; d="scan'208";a="547529382" From: "Liang, Kan" To: Jiri Olsa CC: "acme@kernel.org" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "jolsa@kernel.org" , "namhyung@kernel.org" , "ak@linux.intel.com" , "eranian@google.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH RFC 02/10] perf,tools: Support new sort type --socket Thread-Topic: [PATCH RFC 02/10] perf,tools: Support new sort type --socket Thread-Index: AQHQ2dS6vE9WDKEZU0eaXfJMfAX6MJ4UFf2AgALIVICAAsYSgIABlh4g Date: Mon, 24 Aug 2015 14:22:08 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077018F21A5@SHSMSX103.ccr.corp.intel.com> References: <1439889946-28986-1-git-send-email-kan.liang@intel.com> <1439889946-28986-3-git-send-email-kan.liang@intel.com> <20150820090913.GB1672@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F077018F1D04@SHSMSX103.ccr.corp.intel.com> <20150823220011.GC11582@krava.redhat.com> In-Reply-To: <20150823220011.GC11582@krava.redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 42 > > On Fri, Aug 21, 2015 at 08:25:24PM +0000, Liang, Kan wrote: > > SNIP > > > > > > > we need global topology information in perf.data and use the mapping > > > from there, we can't use current server info > > > > > > we currently store core_siblings_list and thread_siblings_list, in > > > topology FEATURE, which is probably not enough > > > > > > > core_siblings_list includes the cpu list in the same socket. > > thread_siblings_list includes the cpu list in the same core. > > numa_nodes includes the cpu list for each node. > > > > It looks we have enough data from topology FEATURE. > > hum, haven't hecked deeply.. how will you get core id for cpu? > from thread_siblings_list. I just noticed that svg_build_topology_map did the similar thing to get topology map for timechart from perf header. > > > > What do you think about the function as below? > > It gets the socket id from env. > > some sort of caching would be nice, I guess we could store those cpumap > objects within perf_session_env Yes it will be stored in perf_session_env. Thanks, Kan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/