Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754758AbbHXO4J (ORCPT ); Mon, 24 Aug 2015 10:56:09 -0400 Received: from www.linutronix.de ([62.245.132.108]:47079 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753594AbbHXO4H (ORCPT ); Mon, 24 Aug 2015 10:56:07 -0400 Date: Mon, 24 Aug 2015 16:55:33 +0200 (CEST) From: Thomas Gleixner To: Qais Yousef cc: alsa-devel@alsa-project.org, Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH 01/10] irqchip: irq-mips-gic: export gic_send_ipi In-Reply-To: <55DB15EB.3090109@imgtec.com> Message-ID: References: <1440419959-14315-1-git-send-email-qais.yousef@imgtec.com> <1440419959-14315-2-git-send-email-qais.yousef@imgtec.com> <55DB15EB.3090109@imgtec.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 33 On Mon, 24 Aug 2015, Qais Yousef wrote: > On 08/24/2015 01:49 PM, Thomas Gleixner wrote: > > On Mon, 24 Aug 2015, Qais Yousef wrote: > > > > > Some drivers might require to send ipi to other cores. So export it. > > Which IPIs do you need to send from a driver which are not exposed by > > the SMP functions already? > > It's not an SMP IPI. We use GIC to exchange interrupts between AXD and the > host system since AXD is another MIPS core in the cluster. So that should have been in the changelog to begin with. > > > This will be used later by AXD driver. > > That smells fishy and it wants a proper explanation WHY and not just a > > sloppy statement that it will be used later. I can figure that out > > myself as exporting a function without using it does not make any sense. > > Sorry for the terse explanation. As pointed above AXD uses GIC to send and > receive interrupts to the host core. Without this change I can't compile the > driver as a driver module because the symbol is not exported. Really? Exporting it solves that problem then. That's interesting news for me. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/