Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754771AbbHXPCT (ORCPT ); Mon, 24 Aug 2015 11:02:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:58453 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753727AbbHXPCS (ORCPT ); Mon, 24 Aug 2015 11:02:18 -0400 Subject: Re: [PATCHv3 1/5] mm: drop page->slab_page To: "Kirill A. Shutemov" , Andrew Morton , Hugh Dickins References: <1439976106-137226-1-git-send-email-kirill.shutemov@linux.intel.com> <1439976106-137226-2-git-send-email-kirill.shutemov@linux.intel.com> Cc: Andrea Arcangeli , Dave Hansen , Johannes Weiner , Michal Hocko , David Rientjes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim , Andi Kleen From: Vlastimil Babka Message-ID: <55DB31F8.4020200@suse.cz> Date: Mon, 24 Aug 2015 17:02:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1439976106-137226-2-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 44 On 08/19/2015 11:21 AM, Kirill A. Shutemov wrote: > Since 8456a648cf44 ("slab: use struct page for slab management") nobody > uses slab_page field in struct page. > > Let's drop it. Ah, how about dropping this comment in mm/slab.c:slab_destroy() as well? /* * RCU free overloads the RCU head over the LRU. * slab_page has been overloeaded over the LRU, * however it is not used from now on so that * we can use it safely. */ > Signed-off-by: Kirill A. Shutemov > Acked-by: Christoph Lameter > Acked-by: David Rientjes > Cc: Joonsoo Kim > Cc: Andi Kleen > --- > include/linux/mm_types.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 0038ac7466fd..58620ac7f15c 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -140,7 +140,6 @@ struct page { > #endif > }; > > - struct slab *slab_page; /* slab fields */ > struct rcu_head rcu_head; /* Used by SLAB > * when destroying via RCU > */ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/