Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754953AbbHXQ0f (ORCPT ); Mon, 24 Aug 2015 12:26:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38177 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbbHXQ0e (ORCPT ); Mon, 24 Aug 2015 12:26:34 -0400 Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks] To: Chen Bough , Jiri Slaby , Ulf Hansson References: <55B9EF02.7040404@suse.cz> <55BF36D6.4080504@suse.cz> <55C1F919.4080002@suse.cz> <55C227B4.3030102@suse.cz> <55C323A5.6050303@suse.cz> Cc: "linux-mmc@vger.kernel.org" , Linux kernel mailing list From: Laura Abbott Message-ID: <55DB45B8.3020106@redhat.com> Date: Mon, 24 Aug 2015 09:26:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 47 On 08/06/2015 02:17 AM, Chen Bough wrote: > I will format a patch based on your diff file firstly. I will test this on my side, > If any issue, like dma issue or performance issue, I will add some modification. > Then I will send the patch for review, and you can test the patch on your platform. > > Best Regards > Haibo Chen > Did I miss the follow up patch or is this still pending? If it's still pending, would you mind Ccing me when it's available for testing? Thanks, Laura > >> -----Original Message----- >> From: Jiri Slaby [mailto:jslaby@suse.cz] >> Sent: Thursday, August 06, 2015 5:07 PM >> To: Chen Haibo-B51421; Ulf Hansson >> Cc: linux-mmc@vger.kernel.org; Linux kernel mailing list >> Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) >> DMA leaks] >> >> On 08/06/2015, 09:42 AM, Chen Bough wrote: >>> I read your attached log and patch, yes, dma memory leak will happen >>> when more than one pre_request execute. The method of ++next->cookie >>> is not good, your patch seems good, but I still need some time to test >>> the patch, because you unmap the dma in sdhci_finish_data rather than >> the sdhci_post_req. >> >> Hi, >> >> yes, this is not correct. We can perhaps differentiate according to the >> COOKIE value. Should I fix it or are you going to prepare a patch based >> on my RFC? >> >> thanks, >> -- >> js >> suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/