Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754031AbbHXQic (ORCPT ); Mon, 24 Aug 2015 12:38:32 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36609 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbbHXQi3 (ORCPT ); Mon, 24 Aug 2015 12:38:29 -0400 Message-ID: <55DB487E.5020409@synopsys.com> Date: Mon, 24 Aug 2015 22:08:22 +0530 From: Vineet Gupta Organization: Synopsys User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Alexey Brodkin , "linux-arch@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "arc-linux-dev@synopsys.com" , "peterz@infradead.org" , Arnaldo Carvalho de Melo Subject: Re: [PATCH v3 4/6] ARCv2: perf: implement exclusion of event counting in user or kernel mode References: <1440426023-2792-1-git-send-email-abrodkin@synopsys.com> <1440426023-2792-5-git-send-email-abrodkin@synopsys.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 58 On Monday 24 August 2015 08:00 PM, Vineet Gupta wrote: > On Monday 24 August 2015 07:50 PM, Alexey Brodkin wrote: >> > Cc: Peter Zijlstra >> > Cc: Arnaldo Carvalho de Melo >> > Signed-off-by: Alexey Brodkin >> > --- >> > >> > No changes since v2. >> > >> > No changes since v1. >> > >> > .... >> > } >> > >> > + hwc->config = 0; >> > + >> > + if (is_isa_arcv2()) { >> > + /* "exclude user" means "count only kernel" */ >> > + if (event->attr.exclude_user) >> > + hwc->config |= ARC_REG_PCT_CONFIG_KERN; >> > + >> > + /* "exclude kernel" means "count only user" */ >> > + if (event->attr.exclude_kernel) >> > + hwc->config |= ARC_REG_PCT_CONFIG_USER; >> > + } >> > + >> > switch (event->attr.type) { >> > case PERF_TYPE_HARDWARE: >> > if (event->attr.config >= PERF_COUNT_HW_MAX) >> > return -ENOENT; >> > if (arc_pmu->ev_hw_idx[event->attr.config] < 0) >> > return -ENOENT; >> > - hwc->config = arc_pmu->ev_hw_idx[event->attr.config]; >> > + hwc->config |= arc_pmu->ev_hw_idx[event->attr.config]; > With raw events patch dropped - this hunk need not be present. Please ignore this stupid comment - this was written when I was presumably smoking pot ! > >> > pr_debug("init event %d with h/w %d \'%s\'\n", >> > (int) event->attr.config, (int) hwc->config, >> > arc_pmu_ev_hw_map[event->attr.config]); >> > @@ -163,7 +175,7 @@ static int arc_pmu_event_init(struct perf_event *event) >> > ret = arc_pmu_cache_event(event->attr.config); >> > if (ret < 0) >> > return ret; >> > - hwc->config = arc_pmu->ev_hw_idx[ret]; >> > + hwc->config |= arc_pmu->ev_hw_idx[ret]; >> > return 0; >> > default: >> > return -ENOENT; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/