Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932485AbbHXSf6 (ORCPT ); Mon, 24 Aug 2015 14:35:58 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:36773 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932373AbbHXSf4 (ORCPT ); Mon, 24 Aug 2015 14:35:56 -0400 Message-ID: <55DB6379.7040009@gmail.com> Date: Mon, 24 Aug 2015 11:33:29 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Masahiro Yamada , arm@kernel.org CC: Scott Branden , linux-kernel@vger.kernel.org, Russell King , Brian Norris , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Gregory Fong , Ray Jui , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/18] ARM: BCM: use const and __initconst for smp_operations References: <1440390978-22796-1-git-send-email-yamada.masahiro@socionext.com> <1440390978-22796-6-git-send-email-yamada.masahiro@socionext.com> In-Reply-To: <1440390978-22796-6-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2476 Lines: 68 On 23/08/15 21:36, Masahiro Yamada wrote: > The smp_operations structure is not over-written, so add const > qualifier and replace __initdata with __initconst. > > Also, add static to bcm63138_smp_ops. > > Signed-off-by: Masahiro Yamada For bcm63xx and brcmstb: Reviewed-by: Florian Fainelli > --- > > arch/arm/mach-bcm/bcm63xx_smp.c | 2 +- > arch/arm/mach-bcm/kona_smp.c | 2 +- > arch/arm/mach-bcm/platsmp-brcmstb.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-bcm/bcm63xx_smp.c b/arch/arm/mach-bcm/bcm63xx_smp.c > index 19be904..9b6727e 100644 > --- a/arch/arm/mach-bcm/bcm63xx_smp.c > +++ b/arch/arm/mach-bcm/bcm63xx_smp.c > @@ -161,7 +161,7 @@ static void __init bcm63138_smp_prepare_cpus(unsigned int max_cpus) > } > } > > -struct smp_operations bcm63138_smp_ops __initdata = { > +static const struct smp_operations bcm63138_smp_ops __initconst = { > .smp_prepare_cpus = bcm63138_smp_prepare_cpus, > .smp_boot_secondary = bcm63138_smp_boot_secondary, > }; > diff --git a/arch/arm/mach-bcm/kona_smp.c b/arch/arm/mach-bcm/kona_smp.c > index 66a0465..da8328b 100644 > --- a/arch/arm/mach-bcm/kona_smp.c > +++ b/arch/arm/mach-bcm/kona_smp.c > @@ -194,7 +194,7 @@ static int bcm_boot_secondary(unsigned int cpu, struct task_struct *idle) > return -ENOSYS; > } > > -static struct smp_operations bcm_smp_ops __initdata = { > +static const struct smp_operations bcm_smp_ops __initconst = { > .smp_prepare_cpus = bcm_smp_prepare_cpus, > .smp_boot_secondary = bcm_boot_secondary, > }; > diff --git a/arch/arm/mach-bcm/platsmp-brcmstb.c b/arch/arm/mach-bcm/platsmp-brcmstb.c > index 44d6bddf..40dc844 100644 > --- a/arch/arm/mach-bcm/platsmp-brcmstb.c > +++ b/arch/arm/mach-bcm/platsmp-brcmstb.c > @@ -356,7 +356,7 @@ static int brcmstb_boot_secondary(unsigned int cpu, struct task_struct *idle) > return 0; > } > > -static struct smp_operations brcmstb_smp_ops __initdata = { > +static const struct smp_operations brcmstb_smp_ops __initconst = { > .smp_prepare_cpus = brcmstb_cpu_ctrl_setup, > .smp_boot_secondary = brcmstb_boot_secondary, > #ifdef CONFIG_HOTPLUG_CPU > -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/