Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755427AbbHXTAo (ORCPT ); Mon, 24 Aug 2015 15:00:44 -0400 Received: from mail-qk0-f180.google.com ([209.85.220.180]:33983 "EHLO mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbbHXTAl (ORCPT ); Mon, 24 Aug 2015 15:00:41 -0400 Date: Mon, 24 Aug 2015 15:00:37 -0400 From: Tejun Heo To: Aleksa Sarai Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 2/2] cgroup: pids: fix invalid get/put usage Message-ID: <20150824190037.GC28944@mtj.duckdns.org> References: <1440335432-4202-1-git-send-email-cyphar@cyphar.com> <1440335432-4202-3-git-send-email-cyphar@cyphar.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440335432-4202-3-git-send-email-cyphar@cyphar.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 21 Hello, On Sun, Aug 23, 2015 at 11:10:32PM +1000, Aleksa Sarai wrote: > Fix incorrect usage of css_get and css_put to put a different css in > pids_{cancel_,}attach() than the one grabbed in pids_can_attach(). This > could lead to quite serious memory leakage (and unsafe operations on the > putted css). So, this patch looks correct to me but can you update the description so that it notes that the source css doesn't go away while migration is in progress and thus pinning is unnecessary to begin with? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/