Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754414AbbHXTfG (ORCPT ); Mon, 24 Aug 2015 15:35:06 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:35542 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753920AbbHXTfE (ORCPT ); Mon, 24 Aug 2015 15:35:04 -0400 Date: Mon, 24 Aug 2015 22:33:56 +0300 From: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= To: Aparna Karuthodi Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, noralf@tronnes.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: Made into two lines Message-ID: <20150824193356.GB19781@ghost> References: <1440162519-9282-1-git-send-email-kdasaparna@gmail.com> <1440336623-5194-1-git-send-email-kdasaparna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440336623-5194-1-git-send-email-kdasaparna@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 43 On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: > Oh! Sorry! I made the changes to correct the faults you figured out. > Is it okay now? Better. Also, submit it again with proper commit message and put "PATCH v2" in the subject. > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/fbtft/fb_pcd8544.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c > index cf87ce8..925511f 100644 > --- a/drivers/staging/fbtft/fb_pcd8544.c > +++ b/drivers/staging/fbtft/fb_pcd8544.c > @@ -34,8 +34,8 @@ > #define WIDTH 84 > #define HEIGHT 48 > #define TXBUFLEN (84*6) > -#define DEFAULT_GAMMA "40" > /* gamma is used to control contrast in this driver */ Aren't these two supposed to be on the same line? I think your patch is a bit messed up. Doublecheck this. > +#define DEFAULT_GAMMA "40" > > static unsigned tc; > module_param(tc, uint, 0); > -- > 1.7.9.5 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/