Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032AbbHXT6n (ORCPT ); Mon, 24 Aug 2015 15:58:43 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:32843 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbbHXT6m (ORCPT ); Mon, 24 Aug 2015 15:58:42 -0400 MIME-Version: 1.0 In-Reply-To: <1440390978-22796-18-git-send-email-yamada.masahiro@socionext.com> References: <1440390978-22796-1-git-send-email-yamada.masahiro@socionext.com> <1440390978-22796-18-git-send-email-yamada.masahiro@socionext.com> Date: Mon, 24 Aug 2015 15:58:40 -0400 Message-ID: Subject: Re: [PATCH 17/18] ARM: zynq: use const and __initconst for smp_operations From: Moritz Fischer To: Masahiro Yamada Cc: arm@kernel.org, Russell King , Michal Simek , linux-kernel@vger.kernel.org, =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2020 Lines: 57 Acked-by: Moritz Fischer Thanks, Moritz On Mon, Aug 24, 2015 at 12:36 AM, Masahiro Yamada wrote: > The smp_operations structure is not over-written, so add const > qualifier and replace __initdata with __initconst. > > Signed-off-by: Masahiro Yamada > --- > > arch/arm/mach-zynq/common.h | 2 +- > arch/arm/mach-zynq/platsmp.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-zynq/common.h b/arch/arm/mach-zynq/common.h > index 79cda2e..e771933 100644 > --- a/arch/arm/mach-zynq/common.h > +++ b/arch/arm/mach-zynq/common.h > @@ -30,7 +30,7 @@ extern char zynq_secondary_trampoline; > extern char zynq_secondary_trampoline_jump; > extern char zynq_secondary_trampoline_end; > extern int zynq_cpun_start(u32 address, int cpu); > -extern struct smp_operations zynq_smp_ops __initdata; > +extern const struct smp_operations zynq_smp_ops; > #endif > > extern void __iomem *zynq_scu_base; > diff --git a/arch/arm/mach-zynq/platsmp.c b/arch/arm/mach-zynq/platsmp.c > index f66816c..7cd9865 100644 > --- a/arch/arm/mach-zynq/platsmp.c > +++ b/arch/arm/mach-zynq/platsmp.c > @@ -157,7 +157,7 @@ static void zynq_cpu_die(unsigned int cpu) > } > #endif > > -struct smp_operations zynq_smp_ops __initdata = { > +const struct smp_operations zynq_smp_ops __initconst = { > .smp_init_cpus = zynq_smp_init_cpus, > .smp_prepare_cpus = zynq_smp_prepare_cpus, > .smp_boot_secondary = zynq_boot_secondary, > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/