Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754496AbbHXUYb (ORCPT ); Mon, 24 Aug 2015 16:24:31 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:10683 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753993AbbHXUY3 (ORCPT ); Mon, 24 Aug 2015 16:24:29 -0400 X-IronPort-AV: E=Sophos;i="5.15,740,1432623600"; d="scan'208";a="73132264" Subject: Re: [PATCH 05/18] ARM: BCM: use const and __initconst for smp_operations To: Florian Fainelli , Masahiro Yamada , References: <1440390978-22796-1-git-send-email-yamada.masahiro@socionext.com> <1440390978-22796-6-git-send-email-yamada.masahiro@socionext.com> <55DB6379.7040009@gmail.com> CC: Scott Branden , , Russell King , Brian Norris , , Gregory Fong , From: Ray Jui Message-ID: <55DB7D7A.5070704@broadcom.com> Date: Mon, 24 Aug 2015 13:24:26 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55DB6379.7040009@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2064 Lines: 61 On 8/24/2015 11:33 AM, Florian Fainelli wrote: > On 23/08/15 21:36, Masahiro Yamada wrote: >> The smp_operations structure is not over-written, so add const >> qualifier and replace __initdata with __initconst. >> >> Also, add static to bcm63138_smp_ops. >> >> Signed-off-by: Masahiro Yamada > > For bcm63xx and brcmstb: > > Reviewed-by: Florian Fainelli > >> --- >> >> arch/arm/mach-bcm/bcm63xx_smp.c | 2 +- >> arch/arm/mach-bcm/kona_smp.c | 2 +- >> arch/arm/mach-bcm/platsmp-brcmstb.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/mach-bcm/bcm63xx_smp.c b/arch/arm/mach-bcm/bcm63xx_smp.c >> index 19be904..9b6727e 100644 >> --- a/arch/arm/mach-bcm/bcm63xx_smp.c >> +++ b/arch/arm/mach-bcm/bcm63xx_smp.c >> @@ -161,7 +161,7 @@ static void __init bcm63138_smp_prepare_cpus(unsigned int max_cpus) >> } >> } >> >> -struct smp_operations bcm63138_smp_ops __initdata = { >> +static const struct smp_operations bcm63138_smp_ops __initconst = { >> .smp_prepare_cpus = bcm63138_smp_prepare_cpus, >> .smp_boot_secondary = bcm63138_smp_boot_secondary, >> }; >> diff --git a/arch/arm/mach-bcm/kona_smp.c b/arch/arm/mach-bcm/kona_smp.c >> index 66a0465..da8328b 100644 >> --- a/arch/arm/mach-bcm/kona_smp.c >> +++ b/arch/arm/mach-bcm/kona_smp.c >> @@ -194,7 +194,7 @@ static int bcm_boot_secondary(unsigned int cpu, struct task_struct *idle) >> return -ENOSYS; >> } >> >> -static struct smp_operations bcm_smp_ops __initdata = { >> +static const struct smp_operations bcm_smp_ops __initconst = { >> .smp_prepare_cpus = bcm_smp_prepare_cpus, >> .smp_boot_secondary = bcm_boot_secondary, >> }; The change to kona_smp.c looks fine to me. Signed-off-by: Ray Jui Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/