Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754306AbbHXVoZ (ORCPT ); Mon, 24 Aug 2015 17:44:25 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:34275 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922AbbHXVoW (ORCPT ); Mon, 24 Aug 2015 17:44:22 -0400 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:157d:e022:a0ab:b617:664b] In-Reply-To: <20150824212127.GH7557@n2100.arm.linux.org.uk> References: <1440390978-22796-1-git-send-email-yamada.masahiro@socionext.com> <20150824212127.GH7557@n2100.arm.linux.org.uk> Date: Mon, 24 Aug 2015 14:44:21 -0700 Message-ID: Subject: Re: [PATCH 00/18] ARM: use const and __initconst for smp_operations From: Olof Johansson To: Russell King - ARM Linux Cc: Masahiro Yamada , "arm@kernel.org" , Andy Gross , Arnd Bergmann , Gregory Clement , Tsahee Zidenberg , Kumar Gala , Jason Cooper , Geert Uytterhoeven , Jun Nie , Ray Jui , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , "linux-samsung-soc@vger.kernel.org" , Heiko Stuebner , David Brown , Scott Branden , Hans de Goede , "open list:ARM/Rockchip SoC..." , Maxime Ripard , Krzysztof Kozlowski , Broadcom Kernel Feedback List , Florian Fainelli , Frederic Weisbecker , Yingjoe Chen , Stephen Warren , Kukjin Kim , =?UTF-8?Q?Emilio_L=C3=B3pez?= , Stephen Boyd , linux-arm-msm , Sebastian Hesselbarth , Andrew Lunn , Brian Norris , Michal Simek , Gregory Fong , Dinh Nguyen , linux-soc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Santosh Shilimkar , Wei Xu , Chen-Yu Tsai , Pavel Machek , "Peter Zijlstra (Intel)" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1460 Lines: 35 On Mon, Aug 24, 2015 at 2:21 PM, Russell King - ARM Linux wrote: > On Mon, Aug 24, 2015 at 02:12:06PM -0700, Olof Johansson wrote: >> Easiest of all would probably be to get the sub-arch patches into one >> release, then switch the prototypes and function definitions in the >> next. If you switch prototypes first you'll get a bunch of warnings, >> right? > > Wrong way around. :) > > If you change the sub-arches to declare the smp operations as const, > and try and pass them into a function which doesn't take a const-pointer, > you'll get a warning. The core bits need to go in first before the > sub-arch patches. Ah yes, my bad. > I think the series has limited value - it allows us to (a) check that a > small quantity of code doesn't write to these things, and (b) allows us > to move the SMP operations structure from __initdata to __initconstdata. > It's still going to end up in the init region which is read/write in any > case, and still gets thrown away. > > Given where we are, I don't think we need to rush this in during the > last week before the merge window opens, even though it's trivial. Agreed. So if you pick it up for 4.4, we'll get the rest for 4.5. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/