Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858AbbHXWQE (ORCPT ); Mon, 24 Aug 2015 18:16:04 -0400 Received: from mail1.windriver.com ([147.11.146.13]:47735 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754766AbbHXWQA (ORCPT ); Mon, 24 Aug 2015 18:16:00 -0400 From: Paul Gortmaker To: Andrew Morton CC: , , Paul Gortmaker , Michal Hocko , Johannes Weiner , Vladimir Davydov , Mel Gorman Subject: [PATCH 04/10] mm: make vmscan.c explicitly non-modular Date: Mon, 24 Aug 2015 18:14:36 -0400 Message-ID: <1440454482-12250-5-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1440454482-12250-1-git-send-email-paul.gortmaker@windriver.com> References: <1440454482-12250-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 53 The Makefile currently controlling compilation of this code is obj-y meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. However one could argue that subsys_initcall() might make more sense. We don't replace module.h with init.h since the file already has that. Cc: Andrew Morton Cc: Michal Hocko Cc: Johannes Weiner Cc: Vladimir Davydov Cc: Mel Gorman Cc: linux-mm@kvack.org Signed-off-by: Paul Gortmaker --- mm/vmscan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 110733a715f6..dd0b58ff3938 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -14,7 +14,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include -#include #include #include #include @@ -3687,8 +3686,7 @@ static int __init kswapd_init(void) hotcpu_notifier(cpu_callback, 0); return 0; } - -module_init(kswapd_init) +device_initcall(kswapd_init) #ifdef CONFIG_NUMA /* -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/