Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754946AbbHXWQU (ORCPT ); Mon, 24 Aug 2015 18:16:20 -0400 Received: from mail1.windriver.com ([147.11.146.13]:47739 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754795AbbHXWQC (ORCPT ); Mon, 24 Aug 2015 18:16:02 -0400 From: Paul Gortmaker To: Andrew Morton CC: , , Paul Gortmaker , Christoph Lameter , Johannes Weiner , Mel Gorman , Michal Hocko , Davidlohr Bueso , Minchan Kim , Joonsoo Kim Subject: [PATCH 06/10] mm: make vmstat.c explicitly non-modular Date: Mon, 24 Aug 2015 18:14:38 -0400 Message-ID: <1440454482-12250-7-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1440454482-12250-1-git-send-email-paul.gortmaker@windriver.com> References: <1440454482-12250-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1895 Lines: 62 The Makefile currently controlling compilation of this code is obj-y meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. However one could argue that subsys_initcall might make more sense here. Cc: Andrew Morton Cc: Christoph Lameter Cc: Johannes Weiner Cc: Mel Gorman Cc: Michal Hocko Cc: Davidlohr Bueso Cc: Minchan Kim Cc: Joonsoo Kim Cc: linux-mm@kvack.org Signed-off-by: Paul Gortmaker --- mm/vmstat.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 1fd0886a389f..e6cd18cc4d75 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include #include @@ -1536,7 +1536,7 @@ static int __init setup_vmstat(void) #endif return 0; } -module_init(setup_vmstat) +device_initcall(setup_vmstat) #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_COMPACTION) @@ -1695,6 +1695,5 @@ fail: debugfs_remove_recursive(extfrag_debug_root); return -ENOMEM; } - -module_init(extfrag_debug_init); +device_initcall(extfrag_debug_init); #endif -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/