Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754728AbbHYAKU (ORCPT ); Mon, 24 Aug 2015 20:10:20 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32605 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbbHYAKR convert rfc822-to-8bit (ORCPT ); Mon, 24 Aug 2015 20:10:17 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <1440454482-12250-2-git-send-email-paul.gortmaker@windriver.com> References: <1440454482-12250-1-git-send-email-paul.gortmaker@windriver.com> <1440454482-12250-2-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH 01/10] mm: make cleancache.c explicitly non-modular From: Konrad Rzeszutek Wilk Date: Mon, 24 Aug 2015 20:10:03 -0400 To: Paul Gortmaker , Andrew Morton CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-ID: X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1589 Lines: 51 On August 24, 2015 6:14:33 PM EDT, Paul Gortmaker wrote: >The Kconfig currently controlling compilation of this code is: > >config CLEANCACHE >bool "Enable cleancache driver to cache clean pages if tmem is present" > >...meaning that it currently is not being built as a module by anyone. Why not make it a tristate? > >Lets remove the couple traces of modularity so that when reading the >driver there is no doubt it is builtin-only. > >Since module_init translates to device_initcall in the non-modular >case, the init ordering remains unchanged with this commit. > >Cc: Konrad Rzeszutek Wilk >Cc: linux-mm@kvack.org >Signed-off-by: Paul Gortmaker >--- > mm/cleancache.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/mm/cleancache.c b/mm/cleancache.c >index 8fc50811119b..ee0646d1c2fa 100644 >--- a/mm/cleancache.c >+++ b/mm/cleancache.c >@@ -11,7 +11,7 @@ > * This work is licensed under the terms of the GNU GPL, version 2. > */ > >-#include >+#include > #include > #include > #include >@@ -316,4 +316,4 @@ static int __init init_cleancache(void) > #endif > return 0; > } >-module_init(init_cleancache) >+device_initcall(init_cleancache) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/