Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754643AbbHYAXA (ORCPT ); Mon, 24 Aug 2015 20:23:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33877 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbbHYAW7 (ORCPT ); Mon, 24 Aug 2015 20:22:59 -0400 Date: Mon, 24 Aug 2015 17:22:57 -0700 From: Stephen Boyd To: Mathieu Olivari Cc: agross@codeaurora.org, galak@codeaurora.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: qcom: add mdio bus on IPQ806x/AP148 Message-ID: <20150825002257.GA19120@codeaurora.org> References: <1440006802-2415-1-git-send-email-mathieu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440006802-2415-1-git-send-email-mathieu@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 56 On 08/19, Mathieu Olivari wrote: > diff --git a/arch/arm/boot/dts/qcom-ipq8064-ap148.dts b/arch/arm/boot/dts/qcom-ipq8064-ap148.dts > index 6886d09..d73df24 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064-ap148.dts > +++ b/arch/arm/boot/dts/qcom-ipq8064-ap148.dts > @@ -19,8 +19,9 @@ > }; > }; > > - alias { > + aliases { Good catch! > serial0 = &uart4; > + mdio-gpio0 = &mdio0; > }; > > chosen { > @@ -93,5 +103,24 @@ > sata@29000000 { > status = "ok"; > }; > + > + mdio0: mdio { This node should be at the root level, not inside the soc node. > + compatible = "virtual,mdio-gpio"; > + #address-cells = <1>; > + #size-cells = <0>; > + gpios = <&qcom_pinmux 1 0 &qcom_pinmux 0 0>; > + pinctrl-0 = <&mdio0_pins>; > + pinctrl-names = "default"; > + > + phy0: ethernet-phy@0 { > + device_type = "ethernet-phy"; > + reg = <0>; > + }; > + > + phy4: ethernet-phy@4 { > + device_type = "ethernet-phy"; > + reg = <4>; > + }; > + }; > }; > }; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/