Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754773AbbHYAss (ORCPT ); Mon, 24 Aug 2015 20:48:48 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:35335 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754612AbbHYAsq (ORCPT ); Mon, 24 Aug 2015 20:48:46 -0400 Message-ID: <55DBBB6C.3010801@acm.org> Date: Mon, 24 Aug 2015 19:48:44 -0500 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Brijesh Singh , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE References: <1440425725-8445-1-git-send-email-brijeshkumar.singh@amd.com> In-Reply-To: <1440425725-8445-1-git-send-email-brijeshkumar.singh@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1901 Lines: 53 Well, I should have compile tested first. On x86_64: CC [M] drivers/char/ipmi/ipmi_si_intf.o In file included from ../drivers/char/ipmi/ipmi_si_intf.c:42:0: ../drivers/char/ipmi/ipmi_si_intf.c:2804:25: error: ?ipmi_match? undeclared here (not in a function) MODULE_DEVICE_TABLE(of, ipmi_match); ^ ../include/linux/module.h:223:21: note: in definition of macro ?MODULE_DEVICE_TABLE? extern const typeof(name) __mod_##type##__##name##_device_table \ ^ ../include/linux/module.h:223:27: error: ?__mod_of__ipmi_match_device_table? aliased to undefined symbol ?ipmi_match? extern const typeof(name) __mod_##type##__##name##_device_table \ ^ ../drivers/char/ipmi/ipmi_si_intf.c:2804:1: note: in expansion of macro ?MODULE_DEVICE_TABLE? MODULE_DEVICE_TABLE(of, ipmi_match); This has to compile on all arches. I'm not sure what is wrong, but I've removed the patch. -corey On 08/24/2015 09:15 AM, Brijesh Singh wrote: > Fix autoloading ipmi modules when using device tree. > > Signed-off-by: Brijesh Singh > --- > drivers/char/ipmi/ipmi_si_intf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 8a45e92..cddc7b0 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -2785,6 +2785,7 @@ static struct platform_driver ipmi_driver = { > .probe = ipmi_probe, > .remove = ipmi_remove, > }; > +MODULE_DEVICE_TABLE(of, ipmi_match); > > #ifdef CONFIG_PARISC > static int ipmi_parisc_probe(struct parisc_device *dev) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/