Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754501AbbHYBeg (ORCPT ); Mon, 24 Aug 2015 21:34:36 -0400 Received: from ozlabs.org ([103.22.144.67]:43622 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbbHYBee (ORCPT ); Mon, 24 Aug 2015 21:34:34 -0400 From: Rusty Russell To: Oleg Nesterov , "Paul E. McKenney" Cc: Ingo Molnar , Linus Torvalds , Peter Zijlstra , Tejun Heo , linux-kernel@vger.kernel.org Subject: Re: parse_args() is too unforgivable? In-Reply-To: <20150824183126.GA8388@redhat.com> References: <20150821174230.GA17867@redhat.com> <20150822163810.GV11078@linux.vnet.ibm.com> <20150824153431.GB24949@redhat.com> <20150824183126.GA8388@redhat.com> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 25 Aug 2015 10:54:46 +0930 Message-ID: <871tesjh29.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 37 Oleg Nesterov writes: > On 08/24, Oleg Nesterov wrote: >> >> I booted the kernel with the additional patch below, and nothing bad has >> happened, > > Until I tried reboot it once with "locktorture.verbose=true" paramater. > It didn't boot. > > This is because parse_args() just aborts after it hits the error, so other > arguments at the same initcall level are simply ignored. > > Fixed by the patch below, but I simply can't believe nobody hit this (imo) > bug before. > > Why does parse_args() do this?? I simply can't understand why parse_args() > adds more random and hard-to-understand problems if one of the args ("=true" > in this particular case) is wrong. > > Yes, the patch below is probably oversimplified / incomplete but imho the > current behaviour is confusing. At least I was greatly confused ;) At least > (I think) it makes sense to let the user know that the rest of command line > was probably ignored. This is nice, but please save and return the error properly; modules need this too. I think nobody hit this before because they notice that they screwed up the commandline and it didn't boot. Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/