Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819AbbHYBhd (ORCPT ); Mon, 24 Aug 2015 21:37:33 -0400 Received: from conssluserg004.nifty.com ([202.248.44.42]:56282 "EHLO conssluserg004-v.nifty.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752773AbbHYBha (ORCPT ); Mon, 24 Aug 2015 21:37:30 -0400 X-Greylist: delayed 75583 seconds by postgrey-1.27 at vger.kernel.org; Mon, 24 Aug 2015 21:37:30 EDT X-Nifty-SrcIP: [209.85.160.174] MIME-Version: 1.0 In-Reply-To: References: <1440390978-22796-1-git-send-email-yamada.masahiro@socionext.com> <20150824212127.GH7557@n2100.arm.linux.org.uk> Date: Tue, 25 Aug 2015 10:37:15 +0900 Message-ID: Subject: Re: [PATCH 00/18] ARM: use const and __initconst for smp_operations From: Masahiro Yamada To: Olof Johansson Cc: Russell King - ARM Linux , Andrew Lunn , Krzysztof Kozlowski , Heiko Stuebner , "Peter Zijlstra (Intel)" , Frederic Weisbecker , Santosh Shilimkar , Dinh Nguyen , Pavel Machek , Florian Fainelli , Stephen Warren , =?UTF-8?Q?Emilio_L=C3=B3pez?= , Michal Simek , Wei Xu , "open list:ARM/Rockchip SoC..." , Chen-Yu Tsai , "arm@kernel.org" , Broadcom Kernel Feedback List , "linux-arm-kernel@lists.infradead.org" , linux-arm-msm , Geert Uytterhoeven , David Brown , Tsahee Zidenberg , Jason Cooper , Arnd Bergmann , Ray Jui , Andy Gross , Hans de Goede , "linux-samsung-soc@vger.kernel.org" , Gregory Fong , Yingjoe Chen , Gregory Clement , linux-soc@vger.kernel.org, Jun Nie , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , Brian Norris , Scott Branden , Stephen Boyd , "linux-kernel@vger.kernel.org" , Kukjin Kim , Kumar Gala , Maxime Ripard , Sebastian Hesselbarth Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1736 Lines: 51 Hi Russell, Olof, 2015-08-25 6:44 GMT+09:00 Olof Johansson : > On Mon, Aug 24, 2015 at 2:21 PM, Russell King - ARM Linux > wrote: >> On Mon, Aug 24, 2015 at 02:12:06PM -0700, Olof Johansson wrote: >>> Easiest of all would probably be to get the sub-arch patches into one >>> release, then switch the prototypes and function definitions in the >>> next. If you switch prototypes first you'll get a bunch of warnings, >>> right? >> >> Wrong way around. :) >> >> If you change the sub-arches to declare the smp operations as const, >> and try and pass them into a function which doesn't take a const-pointer, >> you'll get a warning. The core bits need to go in first before the >> sub-arch patches. > > Ah yes, my bad. > >> I think the series has limited value - it allows us to (a) check that a >> small quantity of code doesn't write to these things, and (b) allows us >> to move the SMP operations structure from __initdata to __initconstdata. >> It's still going to end up in the init region which is read/write in any >> case, and still gets thrown away. >> >> Given where we are, I don't think we need to rush this in during the >> last week before the merge window opens, even though it's trivial. > > Agreed. So if you pick it up for 4.4, we'll get the rest for 4.5. > OK. I will put 01 and 02 to Russell's patch tracker (after waiting for a bit more comments just in case). I will do the rest later. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/