Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754687AbbHYBuX (ORCPT ); Mon, 24 Aug 2015 21:50:23 -0400 Received: from mail-bl2on0122.outbound.protection.outlook.com ([65.55.169.122]:54961 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751990AbbHYBuS (ORCPT ); Mon, 24 Aug 2015 21:50:18 -0400 From: Chen Bough To: Laura Abbott , Jiri Slaby , "Ulf Hansson" CC: "linux-mmc@vger.kernel.org" , "Linux kernel mailing list" Subject: RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks] Thread-Topic: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks] Thread-Index: AQHQz5EPYBUedJp7gE2YIrmK3qyoMZ3+lGoggAAa44CAAACf4IAcxDcAgACct3A= Date: Tue, 25 Aug 2015 01:50:13 +0000 Message-ID: References: <55B9EF02.7040404@suse.cz> <55BF36D6.4080504@suse.cz> <55C1F919.4080002@suse.cz> <55C227B4.3030102@suse.cz> <55C323A5.6050303@suse.cz> <55DB45B8.3020106@redhat.com> In-Reply-To: <55DB45B8.3020106@redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Haibo.Chen@freescale.com; x-originating-ip: [192.158.241.86] x-microsoft-exchange-diagnostics: 1;BY1PR03MB1388;5:l/+m91wO3mbFfRqFvo/Cu4nv6RYyfaj8A1u8tM0oJa06dVZW3Z/PZzIqw1cDpWIinp6ZcEU1rStJj6ga+NzkdocddsEm4jmxRlsx8NgVW9W5hJWLes4FUGDIavMBMdLEKQ+JD+yAs8+bUepccmNyAw==;24:rOCCkik7RXBFoL3zCGy2cd8LgzKmF1ry6HhT4LFafxvculYSqaNz0l4U6+KumI0p5qEcXyer3A2M1Fg8gC19dMPv4FKiDXh8YG8ayhNNWzA=;20:bNOb3ay8kS5YtiH9a4QUFLLV/c8FbFNAZF8/WZE4TtlwAubbsF+bt3s3uCLFN1UOjaxeQhpgDJRN79/nBGpa6A== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1388; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:BY1PR03MB1388;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1388; x-forefront-prvs: 06793E740F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(13464003)(164054003)(199003)(377454003)(189002)(479174004)(24454002)(122556002)(15975445007)(4001540100001)(46102003)(93886004)(86362001)(106356001)(19580395003)(50986999)(76176999)(33656002)(19580405001)(101416001)(54356999)(40100003)(99286002)(106116001)(5003600100002)(5002640100001)(66066001)(68736005)(76576001)(105586002)(87936001)(74316001)(102836002)(77096005)(5004730100002)(10400500002)(5001770100001)(64706001)(5001830100001)(5007970100001)(5001860100001)(81156007)(97736004)(92566002)(2656002)(62966003)(5001960100002)(5890100001)(5001920100001)(189998001)(2950100001)(2900100001)(77156002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1388;H:BY1PR03MB1388.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2015 01:50:13.9546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1388 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7P1oU9D014791 Content-Length: 2097 Lines: 68 Hi Laura, You can find the patch here: http://patchwork.kernerl.xyz/patch/6967161/ I will send this patch again and cc to you. Best regards Haibo > -----Original Message----- > From: Laura Abbott [mailto:labbott@redhat.com] > Sent: Tuesday, August 25, 2015 12:27 AM > To: Chen Haibo-B51421; Jiri Slaby; Ulf Hansson > Cc: linux-mmc@vger.kernel.org; Linux kernel mailing list > Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) > DMA leaks] > > On 08/06/2015 02:17 AM, Chen Bough wrote: > > I will format a patch based on your diff file firstly. I will test > > this on my side, If any issue, like dma issue or performance issue, I > will add some modification. > > Then I will send the patch for review, and you can test the patch on > your platform. > > > > Best Regards > > Haibo Chen > > > > Did I miss the follow up patch or is this still pending? If it's still > pending, would you mind Ccing me when it's available for testing? > > Thanks, > Laura > > > > >> -----Original Message----- > >> From: Jiri Slaby [mailto:jslaby@suse.cz] > >> Sent: Thursday, August 06, 2015 5:07 PM > >> To: Chen Haibo-B51421; Ulf Hansson > >> Cc: linux-mmc@vger.kernel.org; Linux kernel mailing list > >> Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy > >> (thousands) DMA leaks] > >> > >> On 08/06/2015, 09:42 AM, Chen Bough wrote: > >>> I read your attached log and patch, yes, dma memory leak will happen > >>> when more than one pre_request execute. The method of ++next->cookie > >>> is not good, your patch seems good, but I still need some time to > >>> test the patch, because you unmap the dma in sdhci_finish_data > >>> rather than > >> the sdhci_post_req. > >> > >> Hi, > >> > >> yes, this is not correct. We can perhaps differentiate according to > >> the COOKIE value. Should I fix it or are you going to prepare a patch > >> based on my RFC? > >> > >> thanks, > >> -- > >> js > >> suse labs ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?