Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754844AbbHYCEq (ORCPT ); Mon, 24 Aug 2015 22:04:46 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:33786 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbbHYCEp convert rfc822-to-8bit (ORCPT ); Mon, 24 Aug 2015 22:04:45 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE From: yalin wang In-Reply-To: <55DBBB6C.3010801@acm.org> Date: Tue, 25 Aug 2015 10:04:38 +0800 Cc: Brijesh Singh , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <19EBCACB-31F4-4559-A8A1-7ABD67DD8D22@gmail.com> References: <1440425725-8445-1-git-send-email-brijeshkumar.singh@amd.com> <55DBBB6C.3010801@acm.org> To: minyard@acm.org X-Mailer: Apple Mail (2.2104) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1375 Lines: 37 > On Aug 25, 2015, at 08:48, Corey Minyard wrote: > > Well, I should have compile tested first. On x86_64: > > > CC [M] drivers/char/ipmi/ipmi_si_intf.o > In file included from ../drivers/char/ipmi/ipmi_si_intf.c:42:0: > ../drivers/char/ipmi/ipmi_si_intf.c:2804:25: error: ?ipmi_match? > undeclared here (not in a function) > MODULE_DEVICE_TABLE(of, ipmi_match); > ^ > ../include/linux/module.h:223:21: note: in definition of macro > ?MODULE_DEVICE_TABLE? > extern const typeof(name) __mod_##type##__##name##_device_table \ > ^ > ../include/linux/module.h:223:27: error: > ?__mod_of__ipmi_match_device_table? aliased to undefined symbol ?ipmi_match? > extern const typeof(name) __mod_##type##__##name##_device_table \ > ^ > ../drivers/char/ipmi/ipmi_si_intf.c:2804:1: note: in expansion of macro > ?MODULE_DEVICE_TABLE? > MODULE_DEVICE_TABLE(of, ipmi_match); > > > This has to compile on all arches. I'm not sure what is wrong, but I've > removed the patch. > > -corey it seems should be : MODULE_DEVICE_TABLE(of, of_ipmi_match); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/