Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755337AbbHYGys (ORCPT ); Tue, 25 Aug 2015 02:54:48 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33181 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755159AbbHYGyo (ORCPT ); Tue, 25 Aug 2015 02:54:44 -0400 From: Peng Sun To: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Peng Sun Subject: [PATCH 6/6] fix android/timed_gpio.c several coding style issues Date: Tue, 25 Aug 2015 14:53:52 +0800 Message-Id: <1440485632-17242-7-git-send-email-sironhide0null@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1440485632-17242-6-git-send-email-sironhide0null@gmail.com> References: <1440485632-17242-1-git-send-email-sironhide0null@gmail.com> <1440485632-17242-2-git-send-email-sironhide0null@gmail.com> <1440485632-17242-3-git-send-email-sironhide0null@gmail.com> <1440485632-17242-4-git-send-email-sironhide0null@gmail.com> <1440485632-17242-5-git-send-email-sironhide0null@gmail.com> <1440485632-17242-6-git-send-email-sironhide0null@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2077 Lines: 68 Corrections based on checkpatch.pl with --strict 1) Please don't use multiple blank lines 2) spinlock_t definition without comment 3) Alignment should match open parenthesis Signed-off-by: Peng Sun --- drivers/staging/android/timed_gpio.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c index ce11726..33acbbe 100644 --- a/drivers/staging/android/timed_gpio.c +++ b/drivers/staging/android/timed_gpio.c @@ -25,11 +25,10 @@ #include "timed_output.h" #include "timed_gpio.h" - struct timed_gpio_data { struct timed_output_dev dev; struct hrtimer timer; - spinlock_t lock; + spinlock_t lock; /* protect structure fields */ unsigned gpio; int max_timeout; u8 active_low; @@ -76,8 +75,9 @@ static void gpio_enable(struct timed_output_dev *dev, int value) value = data->max_timeout; hrtimer_start(&data->timer, - ktime_set(value / 1000, (value % 1000) * 1000000), - HRTIMER_MODE_REL); + ktime_set(value / 1000, (value % 1000) * + 1000000), + HRTIMER_MODE_REL); } spin_unlock_irqrestore(&data->lock, flags); @@ -94,8 +94,9 @@ static int timed_gpio_probe(struct platform_device *pdev) return -EBUSY; gpio_data = devm_kzalloc(&pdev->dev, - sizeof(struct timed_gpio_data) * pdata->num_gpios, - GFP_KERNEL); + sizeof(struct timed_gpio_data) * + pdata->num_gpios, + GFP_KERNEL); if (!gpio_data) return -ENOMEM; @@ -104,7 +105,7 @@ static int timed_gpio_probe(struct platform_device *pdev) gpio_dat = &gpio_data[i]; hrtimer_init(&gpio_dat->timer, CLOCK_MONOTONIC, - HRTIMER_MODE_REL); + HRTIMER_MODE_REL); gpio_dat->timer.function = gpio_timer_func; spin_lock_init(&gpio_dat->lock); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/