Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754326AbbHYHbR (ORCPT ); Tue, 25 Aug 2015 03:31:17 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35690 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbbHYHbQ (ORCPT ); Tue, 25 Aug 2015 03:31:16 -0400 Date: Tue, 25 Aug 2015 09:31:11 +0200 From: Richard Cochran To: "Hall, Christopher S" Cc: Thomas Gleixner , "Kirsher, Jeffrey T" , "hpa@zytor.com" , "mingo@redhat.com" , "john.stultz@linaro.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "peterz@infradead.org" Subject: Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl Message-ID: <20150825073111.GB2016@localhost.localdomain> References: <1440183128-1384-1-git-send-email-christopher.s.hall@intel.com> <1440183128-1384-4-git-send-email-christopher.s.hall@intel.com> <20150822211718.GA8561@netboy> <20150823112556.GA8569@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 28 On Mon, Aug 24, 2015 at 08:16:51PM +0000, Hall, Christopher S wrote: > > This means: remove code changes from the PTP_SYS_OFFSET ioctl and call getsynctime64() from a new ioctl PTP_SYS_OFFSET_PRECISE. Right? Yes. > And use the same type (struct ptp_sys_offset) for the new ioctl? Or should a new simplified struct be used? Such as: > > struct precise_ptp_sys_offset { > struct ptp_clock_time device; > struct ptp_clock_time system; > }; I don't have a strong preference either way. I would not mind reusing the existing struct. > Does it make sense to keep the "cross-timestamp" capabilities flag as-is? Yes, indeed. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/