Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755191AbbHYHc4 (ORCPT ); Tue, 25 Aug 2015 03:32:56 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:37189 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755086AbbHYHcx (ORCPT ); Tue, 25 Aug 2015 03:32:53 -0400 Date: Tue, 25 Aug 2015 08:32:49 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard , Jingoo Han , Tomi Valkeinen Subject: Re: [RESEND PATCH 2/7] backlight: tosa: Export I2C module alias information Message-ID: <20150825073249.GB19409@x1> References: <1440484277-32675-1-git-send-email-javier@osg.samsung.com> <1440484277-32675-3-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440484277-32675-3-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1523 Lines: 43 On Tue, 25 Aug 2015, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c:" > regardless of the mechanism that was used to register the device > (i.e: OF or board code) and the table that is used later to match > the driver with the device (i.e: I2C id table or OF match table). > > So drivers needs to export the I2C id table and this be built into > the module or udev won't have the necessary information to autoload > the needed driver module when the device is added. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/video/backlight/tosa_bl.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c > index 3ad676558c80..83742d806391 100644 > --- a/drivers/video/backlight/tosa_bl.c > +++ b/drivers/video/backlight/tosa_bl.c > @@ -158,6 +158,7 @@ static const struct i2c_device_id tosa_bl_id[] = { > { "tosa-bl", 0 }, > { }, > }; > +MODULE_DEVICE_TABLE(i2c, tosa_bl_id); > > static struct i2c_driver tosa_bl_driver = { > .driver = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/