Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755340AbbHYHrz (ORCPT ); Tue, 25 Aug 2015 03:47:55 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:57931 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbbHYHrv convert rfc822-to-8bit (ORCPT ); Tue, 25 Aug 2015 03:47:51 -0400 From: Vineet Gupta To: Geert Uytterhoeven , Yuriy Kolerov , Tomi Valkeinen CC: "linux-kernel@vger.kernel.org" , Linux-Arch , Linux Fbdev development list , Arnd Bergmann , Andrew Morton , Jean-Christophe PLAGNIOL-VILLARD , Alexey Brodkin , "Anton.Kolesov@synopsys.com" , Francois Bedard Subject: Re: [PATCH] ARC: add negative dependency for VGA_CONSOLE Thread-Topic: [PATCH] ARC: add negative dependency for VGA_CONSOLE Thread-Index: AQHQ2QTcn6weTJRwuUOK91AZqNjnlQ== Date: Tue, 25 Aug 2015 07:47:44 +0000 Message-ID: References: <1439826777-11489-1-git-send-email-yuriy.kolerov@synopsys.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.191] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1780 Lines: 49 On Monday 17 August 2015 09:51 PM, Geert Uytterhoeven wrote: > On Mon, Aug 17, 2015 at 5:52 PM, Yuriy Kolerov > wrote: >> Architectures which support VGA console must define screen_info >> structurture from "uapi/linux/screen_info.h". Otherwise undefined >> symbol error occurs. Usually it's defined in "setup.c" for each >> architecture. >> >> If an architecture does not support VGA console (ARC's case) >> there are 2 ways: define a dummy instance of screen_info or add >> a negative dependency for VGA_CONSOLE in to prevent selecting >> this option. >> >> I've implemented the second way. However the best solution is to >> add HAVE_VGA_CONSOLE option for targets which support VGA >> console. Then turn off VGA_CONSOLE by default and add dependency >> to HAVE_VGA_CONSOLE. But right now it's better to just add a >> negative dependency for ARC and then consider how to collaborate >> about this issue with maintainers of other architectures. > +1 > >> Signed-off-by: Yuriy Kolerov > Acked-by: Geert Uytterhoeven Hi Tomi, Is anything else needed for this to be merged. Thx, -Vineet > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/