From: Zhao Qiang <qiang.zhao@freescale.com>
To: Scott Wood <scottwood@freescale.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "lauraa@codeaurora.org" <lauraa@codeaurora.org>,
        Xiaobo Xie <X.Xie@freescale.com>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        Li Leo <LeoLi@freescale.com>, "paulus@samba.org" <paulus@samba.org>
Subject: RE: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage muram
Thread-Topic: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage
 muram
Thread-Index: AQHQ3lE08qg+K0DuDEa/oy40LAO0yp4bWOCAgACc94A=
Date: Tue, 25 Aug 2015 07:52:26 +0000
Message-ID: <SN1PR0301MB1550A026A5C471382BB293A69B610@SN1PR0301MB1550.namprd03.prod.outlook.com>
References: <1440408703-6113-1-git-send-email-qiang.zhao@freescale.com>
	 <1440408703-6113-3-git-send-email-qiang.zhao@freescale.com>
 <1440434073.30043.21.camel@freescale.com>
In-Reply-To: <1440434073.30043.21.camel@freescale.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2015 07:52:26.1829
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1473
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7P7qigm016129
Content-Length: 1853
Lines: 52


On Tue, 2015-08-25 at 12:35 +0800, Wood Scott-B07421 wrote:
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 25, 2015 12:35 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org; Li
> Yang-Leo-R58472; paulus@samba.org
> Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage
> muram
> 
> On Mon, 2015-08-24 at 17:31 +0800, Zhao Qiang wrote:
> 
> > @@ -187,12 +190,41 @@ static inline int qe_alive_during_sleep(void)
> >  }
> >
> >  /* we actually use cpm_muram implementation, define this for
> convenience */
> > -#define qe_muram_init cpm_muram_init
> > -#define qe_muram_alloc cpm_muram_alloc
> > -#define qe_muram_alloc_fixed cpm_muram_alloc_fixed
> > -#define qe_muram_free cpm_muram_free
> > -#define qe_muram_addr cpm_muram_addr
> > -#define qe_muram_offset cpm_muram_offset
> > +int qe_muram_init(void);
> > +
> > +#if defined(CONFIG_QUICC_ENGINE)
> > +unsigned long qe_muram_alloc(unsigned long size, unsigned long align);
> > +int qe_muram_free(unsigned long offset);
> > +void __iomem *qe_muram_addr(unsigned long offset);
> > +unsigned long qe_muram_offset(void __iomem *addr);
> > +dma_addr_t qe_muram_dma(void __iomem *addr);
> > +#else
> > +static inline unsigned long qe_muram_alloc(unsigned long size,
> > +                                         unsigned long align)
> > +{
> > +     return -ENOSYS;
> > +}
> 
> What code calls these functions without CONFIG_QUICC_ENGINE?
> 
> Are you converting qe without cpm?  Why?

CPM just work on PowerPC old boards, it is not necessary to convert it.   

> 
> -Scott


-Zhao
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?