Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755488AbbHYIRO (ORCPT ); Tue, 25 Aug 2015 04:17:14 -0400 Received: from www.linutronix.de ([62.245.132.108]:49935 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754667AbbHYIRL (ORCPT ); Tue, 25 Aug 2015 04:17:11 -0400 Date: Tue, 25 Aug 2015 10:16:33 +0200 (CEST) From: Thomas Gleixner To: Toshi Kani cc: hpa@zytor.com, mingo@redhat.com, akpm@linux-foundation.org, bp@alien8.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com, elliott@hp.com Subject: Re: [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large PAT bit In-Reply-To: <1438811013-30983-4-git-send-email-toshi.kani@hp.com> Message-ID: References: <1438811013-30983-1-git-send-email-toshi.kani@hp.com> <1438811013-30983-4-git-send-email-toshi.kani@hp.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 20 On Wed, 5 Aug 2015, Toshi Kani wrote: > The PAT bit gets relocated to bit 12 when PUD and PMD mappings are > used. This bit 12, however, is not covered by PTE_FLAGS_MASK, which > is corrently used for masking pfn and flags for all cases. > > Fix pud/pmd interfaces to handle pfn and flags properly by using > P?D_PAGE_MASK when PUD/PMD mappings are used, i.e. PSE bit is set. Can you please split that into a patch introducing and describing the new mask helper functions and a second one making use of it? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/