Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755621AbbHYIZX (ORCPT ); Tue, 25 Aug 2015 04:25:23 -0400 Received: from terminus.zytor.com ([198.137.202.10]:38898 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753874AbbHYIZS (ORCPT ); Tue, 25 Aug 2015 04:25:18 -0400 Date: Tue, 25 Aug 2015 01:24:03 -0700 From: "tip-bot for Luis R. Rodriguez" Message-ID: Cc: plagnioj@jcrosoft.com, luto@amacapital.net, jgross@suse.com, laurent.pinchart@ideasonboard.com, geert@linux-m68k.org, bp@suse.de, hpa@zytor.com, robdclark@gmail.com, akpm@linux-foundation.org, tomi.valkeinen@ti.com, adaplas@gmail.com, sbsiddha@gmail.com, airlied@redhat.com, mcgrof@suse.com, tglx@linutronix.de, arnd@arndb.de, linux-kernel@vger.kernel.org, daniel.vetter@ffwll.ch, peterz@infradead.org, mingo@kernel.org, torvalds@linux-foundation.org Reply-To: plagnioj@jcrosoft.com, luto@amacapital.net, jgross@suse.com, laurent.pinchart@ideasonboard.com, geert@linux-m68k.org, bp@suse.de, hpa@zytor.com, robdclark@gmail.com, akpm@linux-foundation.org, tomi.valkeinen@ti.com, adaplas@gmail.com, sbsiddha@gmail.com, airlied@redhat.com, mcgrof@suse.com, arnd@arndb.de, tglx@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org, daniel.vetter@ffwll.ch, torvalds@linux-foundation.org, mingo@kernel.org In-Reply-To: <1440443613-13696-5-git-send-email-mcgrof@do-not-panic.com> References: <1440443613-13696-5-git-send-email-mcgrof@do-not-panic.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/mm] drivers/video/fbdev/gxt4500: Use pci_ioremap_wc_bar( ) to map framebuffer Git-Commit-ID: f3adccbd75831f3651ca6e2cbb83f27cd68a27c9 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3115 Lines: 78 Commit-ID: f3adccbd75831f3651ca6e2cbb83f27cd68a27c9 Gitweb: http://git.kernel.org/tip/f3adccbd75831f3651ca6e2cbb83f27cd68a27c9 Author: Luis R. Rodriguez AuthorDate: Mon, 24 Aug 2015 12:13:26 -0700 Committer: Ingo Molnar CommitDate: Tue, 25 Aug 2015 09:59:44 +0200 drivers/video/fbdev/gxt4500: Use pci_ioremap_wc_bar() to map framebuffer The driver doesn't use mtrr_add() or arch_phys_wc_add() but since we know the framebuffer is isolated already on an ioremap() we can take advantage of write combining for performance where possible. In this case there are a few motivations for this: a) Take advantage of PAT when available. b) Help with the goal of eventually using _PAGE_CACHE_UC over _PAGE_CACHE_UC_MINUS on x86 on ioremap_nocache() (see commit de33c442e titled "x86 PAT: fix performance drop for glx, use UC minus for ioremap(), ioremap_nocache() and pci_mmap_page_range()"). Signed-off-by: Luis R. Rodriguez Signed-off-by: Borislav Petkov Acked-by: Tomi Valkeinen Cc: Andrew Morton Cc: Andy Lutomirski Cc: Antonino Daplas Cc: Arnd Bergmann Cc: Daniel Vetter Cc: Dave Airlie Cc: Geert Uytterhoeven Cc: H. Peter Anvin Cc: Jean-Christophe Plagniol-Villard Cc: Juergen Gross Cc: Laurent Pinchart Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Rob Clark Cc: Suresh Siddha Cc: Thomas Gleixner Cc: airlied@linux.ie Cc: benh@kernel.crashing.org Cc: bhelgaas@google.com Cc: dan.j.williams@intel.com Cc: konrad.wilk@oracle.com Cc: linux-fbdev@vger.kernel.org Cc: linux-pci@vger.kernel.org Cc: mst@redhat.com Cc: toshi.kani@hp.com Cc: vinod.koul@intel.com Cc: xen-devel@lists.xensource.com Link: http://lkml.kernel.org/r/1440443613-13696-5-git-send-email-mcgrof@do-not-panic.com Signed-off-by: Ingo Molnar --- drivers/video/fbdev/gxt4500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c index 135d78a..f19133a 100644 --- a/drivers/video/fbdev/gxt4500.c +++ b/drivers/video/fbdev/gxt4500.c @@ -662,7 +662,7 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent) info->fix.smem_start = fb_phys; info->fix.smem_len = pci_resource_len(pdev, 1); - info->screen_base = pci_ioremap_bar(pdev, 1); + info->screen_base = pci_ioremap_wc_bar(pdev, 1); if (!info->screen_base) { dev_err(&pdev->dev, "gxt4500: cannot map framebuffer\n"); goto err_unmap_regs; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/