Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932315AbbHYIc6 (ORCPT ); Tue, 25 Aug 2015 04:32:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:45907 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755670AbbHYIcz (ORCPT ); Tue, 25 Aug 2015 04:32:55 -0400 Date: Tue, 25 Aug 2015 10:32:49 +0200 From: Jan Kara To: Alexander Kuleshov Cc: Andrew Morton , Tejun Heo , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/backing-dev: Check return value of the debugfs_create_dir() Message-ID: <20150825083249.GB8823@quack.suse.cz> References: <1440489263-3547-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440489263-3547-1-git-send-email-kuleshovmail@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 58 On Tue 25-08-15 13:54:23, Alexander Kuleshov wrote: > The debugfs_create_dir() function may fail and return error. If the > root directory not created, we can't create anything inside it. This > patch adds check for this case. > > Signed-off-by: Alexander Kuleshov The patch looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > mm/backing-dev.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index dac5bf5..518d26a 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -117,15 +117,21 @@ static const struct file_operations bdi_debug_stats_fops = { > > static void bdi_debug_register(struct backing_dev_info *bdi, const char *name) > { > - bdi->debug_dir = debugfs_create_dir(name, bdi_debug_root); > - bdi->debug_stats = debugfs_create_file("stats", 0444, bdi->debug_dir, > - bdi, &bdi_debug_stats_fops); > + if (bdi_debug_root) { > + bdi->debug_dir = debugfs_create_dir(name, bdi_debug_root); > + if (bdi->debug_dir) > + bdi->debug_stats = debugfs_create_file("stats", 0444, > + bdi->debug_dir, bdi, > + &bdi_debug_stats_fops); > + } > } > > static void bdi_debug_unregister(struct backing_dev_info *bdi) > { > - debugfs_remove(bdi->debug_stats); > - debugfs_remove(bdi->debug_dir); > + if (bdi_debug_root) { > + debugfs_remove(bdi->debug_stats); > + debugfs_remove(bdi->debug_dir); > + } > } > #else > static inline void bdi_debug_init(void) > -- > 2.5.0 > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/